Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Nov 17, 2025

Please review the application of the @Serial annotation (JDK-8202385) to types in the java.security.sasl module to enable stricter compile-time checking of serialization-related declarations.

Example of a similar change #27925.

Note: this annotation can be applied to these methods and fields:

  • private void writeObject(java.io.ObjectOutputStream stream) throws IOException
  • private void readObject(java.io.ObjectInputStream stream) throws IOException, ClassNotFoundException
  • private void readObjectNoData() throws ObjectStreamException
  • ANY-ACCESS-MODIFIER Object writeReplace() throws ObjectStreamException
  • ANY-ACCESS-MODIFIER Object readResolve() throws ObjectStreamException
  • private static final ObjectStreamField[] serialPersistentFields
  • private static final long serialVersionUID

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371975: Apply java.io.Serial annotations in java.security.sasl (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28345/head:pull/28345
$ git checkout pull/28345

Update a local copy of the PR:
$ git checkout pull/28345
$ git pull https://git.openjdk.org/jdk.git pull/28345/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28345

View PR using the GUI difftool:
$ git pr show -t 28345

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28345.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the security security-dev@openjdk.org label Nov 17, 2025
@openjdk
Copy link

openjdk bot commented Nov 17, 2025

@mrserb The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mrserb mrserb marked this pull request as ready for review November 18, 2025 00:39
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 18, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant