8372110: GenShen: Fix erroneous assert

[kdnilsen]

Code recently integrated (#27353) had an erroneous (meaningless) assert. Closer examination of intended behavior revealed that the fix involves replacing the assert with a new run-time check, as implemented here.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372110: GenShen: Fix erroneous assert (Enhancement - P4)

Reviewers

• Y. Srinivas Ramakrishna (@ysramakrishna - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28375/head:pull/28375
$ git checkout pull/28375

Update a local copy of the PR:
$ git checkout pull/28375
$ git pull https://git.openjdk.org/jdk.git pull/28375/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28375

View PR using the GUI difftool:
$ git pr show -t 28375

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28375.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kdnilsen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372110: GenShen: Fix erroneous assert

Reviewed-by: ysr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kdnilsen The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (591f09e7)
• 00: Full (86d92901)

[ysramakrishna]

🚢

[kdnilsen]

/integrate

[openjdk]

Going to push as commit aa7718d.
Since your change was applied there have been 17 commits pushed to the master branch:

• b3acc48: 8362894: PKCS12 KeyStore PBMAC1 interoperability testing
• de0a1f8: 8372277: Fix for JDK-8369517 is applied starting from source 24 instead of 26
• ea19ad2: 8347167: Reduce allocation in com.sun.net.httpserver.Headers::normalize
• ... and 14 more: https://git.openjdk.org/jdk/compare/a3b1affbfb23eeef32749164aae316e5d55fffaa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kdnilsen Pushed as commit aa7718d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.