Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Nov 21, 2025

"Normal" test bug: artifact may not be available, so test should be skipped in those conditions. Test failure normally happens in GHA.

Additional testing:

  • Linux x86_64 server fastdebug, test no longer fails
  • GHA

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8372319: com/sun/crypto/provider/Cipher/HPKE/KAT9180 test has external dependencies (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28445/head:pull/28445
$ git checkout pull/28445

Update a local copy of the PR:
$ git checkout pull/28445
$ git pull https://git.openjdk.org/jdk.git pull/28445/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28445

View PR using the GUI difftool:
$ git pr show -t 28445

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28445.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 21, 2025

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372319: com/sun/crypto/provider/Cipher/HPKE/KAT9180 test has external dependencies

Reviewed-by: stuefe, myankelevich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the security security-dev@openjdk.org label Nov 21, 2025
@openjdk
Copy link

openjdk bot commented Nov 21, 2025

@shipilev The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 21, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2025

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 21, 2025
@shipilev
Copy link
Member Author

Thanks for review!

I would like to integrate this soon to make GHA clean again. I would appreciate more reviews :) Also, I think this is trivial.

@tstuefe
Copy link
Member

tstuefe commented Nov 21, 2025

Thanks for review!

I would like to integrate this soon to make GHA clean again. I would appreciate more reviews :) Also, I think this is trivial.

I think this is trivial.

@shipilev
Copy link
Member Author

Thanks! Here goes.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2025

Going to push as commit e24e782.
Since your change was applied there have been 14 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2025
@openjdk openjdk bot closed this Nov 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2025
@openjdk
Copy link

openjdk bot commented Nov 21, 2025

@shipilev Pushed as commit e24e782.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants