Skip to content

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Apr 8, 2021

Small behavioral change to improve the source fidelity of the Xprint output in the case of repeated annotations being placed in a mandated, that is compiler-generated, container annotation.

The checks over and above the annotation being marked as MANDATED are meant to catch potential cases where an annotation was marked as mandated, but was not a container for a repeating annotation.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8005295: Use mandated information for printing of repeating annotations

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3403/head:pull/3403
$ git checkout pull/3403

Update a local copy of the PR:
$ git checkout pull/3403
$ git pull https://git.openjdk.java.net/jdk pull/3403/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3403

View PR using the GUI difftool:
$ git pr show -t 3403

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3403.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 8, 2021

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 8, 2021

@jddarcy The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Apr 8, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 8, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 8, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 9, 2021

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8005295: Use mandated information for printing of repeating annotations

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 9ebc497: 8264765: BreakIterator sees bogus sentence boundary in parenthesized “i.e.” phrase
  • ec31b3a: 8264727: Shenandoah: Remove extraneous whitespace from phase timings report
  • cc54de7: 8264400: (fs) WindowsFileStore equality depends on how the FileStore was constructed
  • 6de0bb2: 8232861: (fc) FileChannel.force fails on WebDAV file systems (macOS)
  • 1ca4abe: 8262881: port JVM/DI tests from JDK-4413752 to JVM/TI
  • 06e6b1f: 8259242: Remove ProtectionDomainSet_lock
  • 9bb1863: 8260923: Add more tests for SSLSocket input/output shutdown
  • 33fa855: 8264732: Clean up LinkResolver::vtable_index_of_interface_method()
  • b3782ea: 8264918: [JVMCI] getVtableIndexForInterfaceMethod doesn't check that type and method are related
  • f7a6c63: 8259822: [PPC64] Support the prefixed instruction format added in POWER10
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/3d2b4cc567777d0849818f5a4cc8fc6394a55f8d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 9, 2021
@jddarcy
Copy link
Member Author

jddarcy commented Apr 9, 2021

/integrate

@openjdk openjdk bot closed this Apr 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 9, 2021
@openjdk
Copy link

openjdk bot commented Apr 9, 2021

@jddarcy Since your change was applied there have been 20 commits pushed to the master branch:

  • f26cd2a: 8264997: Remove SystemDictionary::cache_get
  • 9ebc497: 8264765: BreakIterator sees bogus sentence boundary in parenthesized “i.e.” phrase
  • ec31b3a: 8264727: Shenandoah: Remove extraneous whitespace from phase timings report
  • cc54de7: 8264400: (fs) WindowsFileStore equality depends on how the FileStore was constructed
  • 6de0bb2: 8232861: (fc) FileChannel.force fails on WebDAV file systems (macOS)
  • 1ca4abe: 8262881: port JVM/DI tests from JDK-4413752 to JVM/TI
  • 06e6b1f: 8259242: Remove ProtectionDomainSet_lock
  • 9bb1863: 8260923: Add more tests for SSLSocket input/output shutdown
  • 33fa855: 8264732: Clean up LinkResolver::vtable_index_of_interface_method()
  • b3782ea: 8264918: [JVMCI] getVtableIndexForInterfaceMethod doesn't check that type and method are related
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/3d2b4cc567777d0849818f5a4cc8fc6394a55f8d...master

Your commit was automatically rebased without conflicts.

Pushed as commit 863feab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the 8005295 branch June 10, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants