Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265358: ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64 #3549

Closed
wants to merge 7 commits into from

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Apr 16, 2021

A set of trivial ProblemListing for macos-aarch64 Tier2 test failures:

  • JDK-8265358 ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64
  • JDK-8265361 ProblemList a few compiler/whitebox tests on macos-aarch64
  • JDK-8265363 ProblemList java/net/Socket/UdpSocket.java on macos-aarch64
  • JDK-8265368 ProblemList 3 java/net/httpclient/websocket tests on macos-aarch64
  • JDK-8265370 ProblemList java/net/MulticastSocket/Promiscuous.java on macos-aarch64

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8265358: ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64
  • JDK-8265361: ProblemList a few compiler/whitebox tests on macos-aarch64
  • JDK-8265363: ProblemList java/net/Socket/UdpSocket.java on macos-aarch64
  • JDK-8265368: ProblemList 3 java/net/httpclient/websocket tests on macos-aarch64
  • JDK-8265370: ProblemList java/net/MulticastSocket/Promiscuous.java on macos-aarch64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3549/head:pull/3549
$ git checkout pull/3549

Update a local copy of the PR:
$ git checkout pull/3549
$ git pull https://git.openjdk.java.net/jdk pull/3549/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3549

View PR using the GUI difftool:
$ git pr show -t 3549

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3549.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 16, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Apr 16, 2021

/label add hotspot-runtime
/label add core-libs
/label add hotspot-compiler

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Apr 16, 2021

/issue JDK-8265358
/issue JDK-8265361
/issue JDK-8265363
/issue JDK-8265366
/issue JDK-8265368
/issue JDK-8265370

@openjdk openjdk bot added the core-libs label Apr 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dcubed-ojdk
The core-libs label was successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dcubed-ojdk
The hotspot-compiler label was successfully added.

@openjdk openjdk bot changed the title JDK-8265358 ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64 8265358: ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64 Apr 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dcubed-ojdk
Adding additional issue to issue list: 8265361: ProblemList a few compiler/whitebox tests on macos-aarch64.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dcubed-ojdk
Adding additional issue to issue list: 8265363: ProblemList java/net/Socket/UdpSocket.java on macos-aarch64.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dcubed-ojdk
Adding additional issue to issue list: 8265366: ProblemList 2 javax/net/ssl/DTLS tests on macos-aarch64.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dcubed-ojdk
Adding additional issue to issue list: 8265368: ProblemList 3 java/net/httpclient/websocket tests on macos-aarch64.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dcubed-ojdk
Adding additional issue to issue list: 8265370: ProblemList java/net/MulticastSocket/Promiscuous.java on macos-aarch64.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Apr 16, 2021
@openjdk openjdk bot added the rfr label Apr 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 16, 2021

Webrevs

@bplb
bplb approved these changes Apr 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265358: ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64
8265361: ProblemList a few compiler/whitebox tests on macos-aarch64
8265363: ProblemList java/net/Socket/UdpSocket.java on macos-aarch64
8265368: ProblemList 3 java/net/httpclient/websocket tests on macos-aarch64
8265370: ProblemList java/net/MulticastSocket/Promiscuous.java on macos-aarch64

Reviewed-by: bpb, mikael

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 0bdc3e7: 8262744: Formatter '%g' conversion uses wrong format for BigDecimal rounding up to limits
  • 4413dbf: 8263395: Incorrect use of Objects.nonNull
  • 74d03ab: 8039270: The background color of the button can't be displayed and when pressed the button, the background color can not be changed in accordance with the case described.
  • 7c37c02: 8244190: JFR: When starting a JVM with -XX:StartFlightRecording, output is written to stdout
  • 79adc16: 8264152: javax/net/ssl/DTLS/RespondToRetransmit.java timed out

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 16, 2021
@vidmik
vidmik approved these changes Apr 16, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Apr 16, 2021

@bplb and @vidmik - Thanks for the reviews.

I'm removing the changes for JDK-8265366 at @fguallini's request.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Apr 16, 2021

/id remove JDK-8265366

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dcubed-ojdk Unknown command id - for a list of valid commands use /help.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Apr 16, 2021

/issue remove JDK-8265366

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dcubed-ojdk
Removing additional issue from issue list: 8265366.

@vidmik
vidmik approved these changes Apr 16, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Apr 16, 2021

/integrate

@openjdk openjdk bot closed this Apr 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dcubed-ojdk Since your change was applied there have been 5 commits pushed to the master branch:

  • 0bdc3e7: 8262744: Formatter '%g' conversion uses wrong format for BigDecimal rounding up to limits
  • 4413dbf: 8263395: Incorrect use of Objects.nonNull
  • 74d03ab: 8039270: The background color of the button can't be displayed and when pressed the button, the background color can not be changed in accordance with the case described.
  • 7c37c02: 8244190: JFR: When starting a JVM with -XX:StartFlightRecording, output is written to stdout
  • 79adc16: 8264152: javax/net/ssl/DTLS/RespondToRetransmit.java timed out

Your commit was automatically rebased without conflicts.

Pushed as commit 888d80b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the dcubed-ojdk:JDK-8265358 branch Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants