-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8252837: Cleanup SAP Copyright file headers #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
@RealCLanger The following labels will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the |
Mailing list message from Lindenmaier, Goetz on nio-dev: Hi Christoph, Looks good to me ?? Best regards, -----Original Message----- The format for SAP copyrights in OpenJDK headers should be like: There should not be a comma character (",") before "SAP SE". This is inconsistent in some files which calls for some cleanup. Please review :) ------------- Commit messages: Changes: https://git.openjdk.java.net/jdk/pull/36/files PR: https://git.openjdk.java.net/jdk/pull/36 |
Mailing list message from David Holmes on nio-dev: Looks good to me - and trivial. Thanks, On 7/09/2020 2:22 pm, Christoph Langer wrote: |
@RealCLanger This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there has been 1 commit pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
Thanks, David! |
Thanks, Goetz :) |
/integrate |
@RealCLanger Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit cc5039e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Note that Goetz was not officially added as a reviewer. The email was included in this PR as a comment, but he either has to add himself as a reviewer, or the PR author has to based on the email. |
* package jdk.classfile.transforms API cleanup * simplified CodeLocalsShifter to delegate locals allocation on CodeBuilder * added parent field to NonterminalCodeBuilder * fixed ChainedCodeBuilder::allocateLocal * jdk.classfile.transforms package rename to jdk.classfile.components * ClassPrinter move to jdk.classfile.components package
* package jdk.classfile.transforms API cleanup * simplified CodeLocalsShifter to delegate locals allocation on CodeBuilder * added parent field to NonterminalCodeBuilder * fixed ChainedCodeBuilder::allocateLocal * jdk.classfile.transforms package rename to jdk.classfile.components * ClassPrinter move to jdk.classfile.components package
…dk#36) Co-authored-by: Xin Liu <xxinliu@amazon.com>
The format for SAP copyrights in OpenJDK headers should be like:
Copyright (c) SAP SE. All rights reserved.
or
Copyright (c) , SAP SE. All rights reserved.
There should not be a comma character (",") before "SAP SE".
This is inconsistent in some files which calls for some cleanup.
Please review :)
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/36/head:pull/36
$ git checkout pull/36