Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252837: Cleanup SAP Copyright file headers #36

Closed
wants to merge 1 commit into from

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 7, 2020

The format for SAP copyrights in OpenJDK headers should be like:
Copyright (c) SAP SE. All rights reserved.
or
Copyright (c) , SAP SE. All rights reserved.

There should not be a comma character (",") before "SAP SE".

This is inconsistent in some files which calls for some cleanup.

Please review :)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/36/head:pull/36
$ git checkout pull/36

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 7, 2020

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2020

@RealCLanger The following labels will be automatically applied to this pull request: hotspot net nio serviceability.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 7, 2020

Webrevs

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 7, 2020

Mailing list message from Lindenmaier, Goetz on nio-dev:

Hi Christoph,

Looks good to me ??

Best regards,
Goetz.

-----Original Message-----
From: nio-dev <nio-dev-retn at openjdk.java.net> On Behalf Of Christoph Langer
Sent: Montag, 7. September 2020 06:22
To: hotspot-dev at openjdk.java.net; net-dev at openjdk.java.net; nio-dev at openjdk.java.net; serviceability-dev at openjdk.java.net
Subject: RFR: 8252837: Cleanup SAP Copyright file headers

The format for SAP copyrights in OpenJDK headers should be like:
Copyright (c) <year> SAP SE. All rights reserved.
or
Copyright (c) <year1>, <year2> SAP SE. All rights reserved.

There should not be a comma character (",") before "SAP SE".

This is inconsistent in some files which calls for some cleanup.

Please review :)

-------------

Commit messages:
- 8252837: Cleanup SAP Copyright file headers

Changes: https://git.openjdk.java.net/jdk/pull/36/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=36&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8252837
Stats: 55 lines in 55 files changed: 0 ins; 0 del; 55 mod
Patch: https://git.openjdk.java.net/jdk/pull/36.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/36/head:pull/36

PR: https://git.openjdk.java.net/jdk/pull/36

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 7, 2020

Mailing list message from David Holmes on nio-dev:

Looks good to me - and trivial.

Thanks,
David

On 7/09/2020 2:22 pm, Christoph Langer wrote:

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2020

@RealCLanger This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252837: Cleanup SAP Copyright file headers

Reviewed-by: dholmes
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 55c7e76: 8252825: Add automated test for fix done in JDK-8218479

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 55c7e769c801f95f1c457fecdfbf07bace0a194f.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 7, 2020
@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Sep 7, 2020

Mailing list message from David Holmes on nio-dev:

Looks good to me - and trivial.

Thanks,
David

On 7/09/2020 2:22 pm, Christoph Langer wrote:

Thanks, David!

Loading

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Sep 7, 2020

Mailing list message from Lindenmaier, Goetz on nio-dev:

Hi Christoph,

Looks good to me ??

Best regards,
Goetz.

Thanks, Goetz :)

Loading

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Sep 7, 2020

/integrate

Loading

@openjdk openjdk bot closed this Sep 7, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2020

@RealCLanger Since your change was applied there has been 1 commit pushed to the master branch:

  • 55c7e76: 8252825: Add automated test for fix done in JDK-8218479

Your commit was automatically rebased without conflicts.

Pushed as commit cc5039e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Sep 7, 2020

Note that Goetz was not officially added as a reviewer. The email was included in this PR as a comment, but he either has to add himself as a reviewer, or the PR author has to based on the email.

Loading

@RealCLanger RealCLanger deleted the fix-sap-copyright branch Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants