-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8196415: Disable SHA-1 Signed JARs #3700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back mullan! A progress list of the required criteria for merging this PR into |
|
@seanjmullan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
@seanjmullan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 103 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
@seanjmullan Since your change was applied there have been 143 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 2780577. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This change will restrict JARs signed with SHA-1 algorithms and treat them as if they were unsigned. This applies to the algorithms used to digest, sign, and optionally timestamp the JAR. It also applies to the signature and digest algorithms of the certificates in the certificate chain of the code signer and the Timestamp Authority, and any CRLs or OCSP responses that are used to verify if those certificates have been revoked.
In order to reduce the compatibility risk for applications that have been previously timestamped or use private CAs, there are two exceptions to this policy:
cacertskeystore will not be restricted.These exceptions may be removed in a future JDK release.
All tests are in the closed repo for now.
CSR: https://bugs.openjdk.java.net/browse/JDK-8264362
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3700/head:pull/3700$ git checkout pull/3700Update a local copy of the PR:
$ git checkout pull/3700$ git pull https://git.openjdk.java.net/jdk pull/3700/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3700View PR using the GUI difftool:
$ git pr show -t 3700Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3700.diff