8255227: java/net/httpclient/FlowAdapterPublisherTest.java intermittently failing with TestServer: start exception: java.io.IOException: Invalid preface #3813
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hi,
I stumbled on an issue in Stream.java where an assert was misplaced, preventing the proper IOException to be triggered. I believe this is what caused the FlowAdapterPublisherTest.java to fail with the "Invalid Preface" error on the server side.
In any case - I haven't observed this error again after tweaking the assert.
I have also updated the server side to print better diagnostic in case the Invalid Preface strikes again in the future...
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3813/head:pull/3813
$ git checkout pull/3813
Update a local copy of the PR:
$ git checkout pull/3813
$ git pull https://git.openjdk.java.net/jdk pull/3813/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3813
View PR using the GUI difftool:
$ git pr show -t 3813
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3813.diff