Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266615: C2 incorrectly folds subtype checks involving an interface array #4060

Closed
wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented May 17, 2021

C2 incorrectly folds the subtype checks in TestInterfaceArraySubtypeCheck::test1/test2. As a result, an unexpected ClassCastException is thrown at checkcast and instanceof returns a wrong result. The problem is in Compile::static_subtype_check where we incorrectly return SSC_always_false for the MyInterface[] <: MyClassA[] check because MyClassA[] is not a subtype of MyInterface[] (after checking that MyInterface[] is not a subtype of MyClassA[]).

The fix is to check that subelem is not an interface. This is very old code and not a recent regression.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266615: C2 incorrectly folds subtype checks involving an interface array

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4060/head:pull/4060
$ git checkout pull/4060

Update a local copy of the PR:
$ git checkout pull/4060
$ git pull https://git.openjdk.java.net/jdk pull/4060/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4060

View PR using the GUI difftool:
$ git pr show -t 4060

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4060.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 17, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@TobiHartmann The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label May 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 17, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266615: C2 incorrectly folds subtype checks involving an interface array

Reviewed-by: kvn, neliasso

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 894547d: 8266897: com/sun/net/httpserver/FilterTest.java fails intermittently with AssertionError
  • da7c846: 8264408: test_oopStorage no longer needs to disable some tests on WIN32
  • f6c2891: 8267229: Split runtime/Metaspace/elastic test configurations for better scalability
  • b60975d: 8267237: ARM32: bad AD file in matcher.cpp after 8266810
  • 905b41a: 8265711: C1: Intrinsify Class.getModifier method
  • 554caf3: 8251392: Consolidate Metaspace Statistics
  • 3e97b07: 8267116: Lanai: Incorrect AlphaComposite for VolatileImage graphics
  • cd1c17c: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report
  • 2effdd1: 8267112: JVMCI compiler modules should be kept upgradable
  • da4dfde: 8264777: Overload optimized FileInputStream::readAllBytes
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/a555fd89d040792d4de73ab67d86b171a38cfde6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 17, 2021
@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented May 18, 2021

Thanks for the review, Vladimir!

Copy link

@neliasso neliasso left a comment

Looks good.

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented May 18, 2021

Thanks Nils!

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented May 18, 2021

/integrate

@openjdk openjdk bot closed this May 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@TobiHartmann Since your change was applied there have been 20 commits pushed to the master branch:

  • 894547d: 8266897: com/sun/net/httpserver/FilterTest.java fails intermittently with AssertionError
  • da7c846: 8264408: test_oopStorage no longer needs to disable some tests on WIN32
  • f6c2891: 8267229: Split runtime/Metaspace/elastic test configurations for better scalability
  • b60975d: 8267237: ARM32: bad AD file in matcher.cpp after 8266810
  • 905b41a: 8265711: C1: Intrinsify Class.getModifier method
  • 554caf3: 8251392: Consolidate Metaspace Statistics
  • 3e97b07: 8267116: Lanai: Incorrect AlphaComposite for VolatileImage graphics
  • cd1c17c: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report
  • 2effdd1: 8267112: JVMCI compiler modules should be kept upgradable
  • da4dfde: 8264777: Overload optimized FileInputStream::readAllBytes
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/a555fd89d040792d4de73ab67d86b171a38cfde6...master

Your commit was automatically rebased without conflicts.

Pushed as commit ce88b33.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
3 participants