Skip to content

Conversation

@JesperIRL
Copy link
Member

@JesperIRL JesperIRL commented Jul 8, 2021

Forwardport JDK 17 -> JDK 18


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4734/head:pull/4734
$ git checkout pull/4734

Update a local copy of the PR:
$ git checkout pull/4734
$ git pull https://git.openjdk.java.net/jdk pull/4734/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4734

View PR using the GUI difftool:
$ git pr show -t 4734

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4734.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2021

👋 Welcome back jwilhelm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 8, 2021

@JesperIRL This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Merge

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2021
@openjdk
Copy link

openjdk bot commented Jul 8, 2021

@JesperIRL The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs
  • hotspot-compiler
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Jul 8, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2021

Webrevs

@JesperIRL
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 8, 2021

Going to push as commit dfd6b2b.

@openjdk openjdk bot closed this Jul 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2021
@openjdk
Copy link

openjdk bot commented Jul 8, 2021

@JesperIRL Pushed as commit dfd6b2b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JesperIRL JesperIRL deleted the Merge_jdk17 branch July 8, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

5 participants