-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8271221: [BACKOUT] JDK-8271063 Print injected fields for InstanceKlass #4890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 9b27df6.
|
👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into |
|
/label add hotspot-runtime |
|
@dcubed-ojdk |
coleenp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks yes, this is trivial, please integrate it!
|
@dcubed-ojdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@coleenp - Thanks for the review! /integrate |
|
@dcubed-ojdk Pushed as commit ec71e2d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This reverts commit 9b27df6.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4890/head:pull/4890$ git checkout pull/4890Update a local copy of the PR:
$ git checkout pull/4890$ git pull https://git.openjdk.java.net/jdk pull/4890/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4890View PR using the GUI difftool:
$ git pr show -t 4890Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4890.diff