-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8271170: Add unit test for what jpackage app launcher puts in the environment #5056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8271170: Add unit test for what jpackage app launcher puts in the environment #5056
Conversation
|
👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into |
|
@alexeysemenyukoracle The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
@alexeysemenyukoracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 59 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
These changes will be pushed after https://bugs.openjdk.java.net/browse/JDK-8272328 is fixed. |
|
/integrate |
|
Going to push as commit 44f137f.
Your commit was automatically rebased without conflicts. |
|
@alexeysemenyukoracle Pushed as commit 44f137f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Added jtreg test to verify jpackage launcher adds app dir to
java.library.pathsystem property.Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java.
Moved test/jdk/tools/jpackage/apps/image/Hello.java to test/jdk/tools/jpackage/apps/Hello.java.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5056/head:pull/5056$ git checkout pull/5056Update a local copy of the PR:
$ git checkout pull/5056$ git pull https://git.openjdk.java.net/jdk pull/5056/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5056View PR using the GUI difftool:
$ git pr show -t 5056Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5056.diff