Skip to content

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Aug 9, 2021

Added jtreg test to verify jpackage launcher adds app dir to java.library.path system property.
Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java.
Moved test/jdk/tools/jpackage/apps/image/Hello.java to test/jdk/tools/jpackage/apps/Hello.java.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271170: Add unit test for what jpackage app launcher puts in the environment

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5056/head:pull/5056
$ git checkout pull/5056

Update a local copy of the PR:
$ git checkout pull/5056
$ git pull https://git.openjdk.java.net/jdk pull/5056/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5056

View PR using the GUI difftool:
$ git pr show -t 5056

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5056.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 9, 2021

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 9, 2021

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 9, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 9, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 9, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 9, 2021

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271170: Add unit test for what jpackage app launcher puts in the environment

Reviewed-by: almatvee, herrick

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

  • cd2dbe5: 8272328: java.library.path is not set properly by Windows jpackage app launcher
  • 9faab40: 8272330: C2: Cleanup profile counter scaling
  • 75a0642: 8272335: runtime/cds/appcds/MoveJDKTest.java doesn't check exit codes
  • 9ba8a12: 8269774: doclint reports missing javadoc comments for JavaFX properties if the docs are on the property method
  • ec8d3ba: 8271159: [REDO] JDK-8249634 doclint should report implicit constructor as missing javadoc comments
  • 6194227: 8272228: G1: G1CardSetInlinePtr Fix tautological assertion
  • cd1751c: 8271884: G1CH::_expand_heap_after_alloc_failure is no longer needed
  • 3f723ca: 8271862: C2 intrinsic for Reference.refersTo() is often not used
  • abebbe2: 8267186: Add string deduplication support to ZGC
  • 0d0f2d0: 8272216: G1: replace G1ParScanThreadState::_dest with a constant
  • ... and 49 more: https://git.openjdk.java.net/jdk/compare/62e72adfa7bcc8e2a70c1346f3051deb2488affc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 9, 2021
@alexeysemenyukoracle
Copy link
Member Author

These changes will be pushed after https://bugs.openjdk.java.net/browse/JDK-8272328 is fixed.

@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 11, 2021

Going to push as commit 44f137f.
Since your change was applied there have been 59 commits pushed to the master branch:

  • cd2dbe5: 8272328: java.library.path is not set properly by Windows jpackage app launcher
  • 9faab40: 8272330: C2: Cleanup profile counter scaling
  • 75a0642: 8272335: runtime/cds/appcds/MoveJDKTest.java doesn't check exit codes
  • 9ba8a12: 8269774: doclint reports missing javadoc comments for JavaFX properties if the docs are on the property method
  • ec8d3ba: 8271159: [REDO] JDK-8249634 doclint should report implicit constructor as missing javadoc comments
  • 6194227: 8272228: G1: G1CardSetInlinePtr Fix tautological assertion
  • cd1751c: 8271884: G1CH::_expand_heap_after_alloc_failure is no longer needed
  • 3f723ca: 8271862: C2 intrinsic for Reference.refersTo() is often not used
  • abebbe2: 8267186: Add string deduplication support to ZGC
  • 0d0f2d0: 8272216: G1: replace G1ParScanThreadState::_dest with a constant
  • ... and 49 more: https://git.openjdk.java.net/jdk/compare/62e72adfa7bcc8e2a70c1346f3051deb2488affc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 11, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 11, 2021
@openjdk
Copy link

openjdk bot commented Aug 11, 2021

@alexeysemenyukoracle Pushed as commit 44f137f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants