8272552: mark hotspot runtime/cds tests which ignore external VM flags

[iignatev]

Hi all,

could you please review this patch that adds @requires vm.flagless to runtime/cds tests that ignore external flags?

Thanks,
-- Igor

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8272552: mark hotspot runtime/cds tests which ignore external VM flags

Reviewers

• Mikhailo Seledtsov (@mseledts - Committer)
• Jie Fu (@DamonFool - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5132/head:pull/5132
$ git checkout pull/5132

Update a local copy of the PR:
$ git checkout pull/5132
$ git pull https://git.openjdk.java.net/jdk pull/5132/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5132

View PR using the GUI difftool:
$ git pr show -t 5132

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5132.diff

[bridgekeeper]

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iignatev The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (69331a46)

[mseledts]

Looks good to me.

[openjdk]

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272552: mark hotspot runtime/cds tests which ignore external VM flags

Reviewed-by: mseledtsov, jiefu, dholmes, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• ee8bf10: 8272327: Shenandoah: Avoid enqueuing duplicate string candidates
• 3fb1927: 8271227: Missing {@code } in com.sun.source.*
• a5ad772: 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Looks good.

Though I have to wonder whether some of these tests should be passing flags through, otherwise, for example, how will we know they work with a different GC?

Thanks,
David

[iignatev]

Looks good.

Though I have to wonder whether some of these tests should be passing flags through, otherwise, for example, how will we know they work with a different GC?

so have I, however, the scope of 8272552, and the rest of 8246498's subtask is to properly mark the tests, not to change them. and I hope that after all the marking is done, each component team will be more aware of possible gaps in their test coverage and can improve it where needed.

[iklam]

LGTM

[iignatev]

Ioi, Jie, Misha, David,

thank you for your reviews!

/integrate

[openjdk]

Going to push as commit 989f39f.
Since your change was applied there have been 3 commits pushed to the master branch:

• ee8bf10: 8272327: Shenandoah: Avoid enqueuing duplicate string candidates
• 3fb1927: 8271227: Missing {@code } in com.sun.source.*
• a5ad772: 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions

Your commit was automatically rebased without conflicts.

[openjdk]

@iignatev Pushed as commit 989f39f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.