Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah #5757

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Sep 29, 2021

Fails like this:

$ CONF=linux-x86_64-server-fastdebug make run-test TEST=java/lang/management/ManagementFactory/MXBeanException.java TEST_VM_OPTS="-XX:+UseShenandoahGC"

...

java.lang.NullPointerException: Cannot invoke "java.lang.management.MemoryPoolMXBean.setUsageThreshold(long)" because "MXBeanException.pool" is null

This test tries to find the pool that is !p.isUsageThresholdSupported(), and for Shenandoah there is no such pool. Likewise with ZGC, which is already filtered.

Additional testing:

  • Affected test is now skipped for Shenandoah
  • Affected test is still skipped for Z
  • Affected test is still passing for G1

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5757/head:pull/5757
$ git checkout pull/5757

Update a local copy of the PR:
$ git checkout pull/5757
$ git pull https://git.openjdk.java.net/jdk pull/5757/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5757

View PR using the GUI difftool:
$ git pr show -t 5757

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5757.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 29, 2021
@openjdk
Copy link

openjdk bot commented Sep 29, 2021

@shipilev The following labels will be automatically applied to this pull request:

  • core-libs
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Sep 29, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2021

Webrevs

@AlanBateman
Copy link
Contributor

/label remove core-libs

@openjdk
Copy link

openjdk bot commented Sep 29, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah

Reviewed-by: alanb, mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 79cebe2: 8274050: Unnecessary Vector usage in javax.crypto
  • 97b2874: 8274509: Remove stray * and stylistic . from doc comments
  • b1b6696: 8274453: (sctp) com/sun/nio/sctp/SctpChannel/CloseDescriptors.java test should be resilient to lsof warnings
  • edd9d1c: 8274330: Incorrect encoding of the DistributionPointName object in IssuingDistributionPointExtension
  • 980c50d: 8272562: C2: assert(false) failed: Bad graph detected in build_loop_late
  • 1dc8fa9: 8274340: [BACKOUT] JDK-8271880: Tighten condition for excluding regions from collecting cards with cross-references
  • aaa36cc: 8274242: Implement fast-path for ASCII-compatible CharsetEncoders on x86
  • c4d1157: 8271855: [TESTBUG] Wrong weakCompareAndSet assumption in UnsafeIntrinsicsTest
  • 756d22c: 8274130: C2: MulNode::Ideal chained transformations may act on wrong nodes
  • 5b0c9cc: 8274172: Convert JavadocTester to use NIO
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/79865cd797737f22cd4efe7e9c03ddbb86095e64...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed core-libs core-libs-dev@openjdk.org labels Sep 29, 2021
@openjdk
Copy link

openjdk bot commented Sep 29, 2021

@AlanBateman
The core-libs label was successfully removed.

@shipilev
Copy link
Member Author

Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Sep 30, 2021

Going to push as commit c0533ef.
Since your change was applied there have been 27 commits pushed to the master branch:

  • f8415a9: 8274523: java/lang/management/MemoryMXBean/MemoryTest.java test should handle Shenandoah
  • 355356c: 8273435: Remove redundant zero-length check in ClassDesc.of
  • 97385d4: 8274405: Suppress warnings on non-serializable non-transient instance fields in javac and javadoc
  • 79cebe2: 8274050: Unnecessary Vector usage in javax.crypto
  • 97b2874: 8274509: Remove stray * and stylistic . from doc comments
  • b1b6696: 8274453: (sctp) com/sun/nio/sctp/SctpChannel/CloseDescriptors.java test should be resilient to lsof warnings
  • edd9d1c: 8274330: Incorrect encoding of the DistributionPointName object in IssuingDistributionPointExtension
  • 980c50d: 8272562: C2: assert(false) failed: Bad graph detected in build_loop_late
  • 1dc8fa9: 8274340: [BACKOUT] JDK-8271880: Tighten condition for excluding regions from collecting cards with cross-references
  • aaa36cc: 8274242: Implement fast-path for ASCII-compatible CharsetEncoders on x86
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/79865cd797737f22cd4efe7e9c03ddbb86095e64...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 30, 2021
@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@shipilev Pushed as commit c0533ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8274522-shenandoah-mf branch October 11, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants