Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274753: ZGC: SEGV in MetaspaceShared::link_shared_classes #5859

Closed
wants to merge 2 commits into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Oct 7, 2021

This change replaces the Handles with OopHandles in CollectCLDClasses so they don't get GC'd. Handles aren't good enough because of the HandleMark in ClassLoaderDataGraphIterator. It also fixes the issue with leaving stale error klass in the dumptime_table and adds a test.
Tested with tier1-6.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5859/head:pull/5859
$ git checkout pull/5859

Update a local copy of the PR:
$ git checkout pull/5859
$ git pull https://git.openjdk.java.net/jdk pull/5859/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5859

View PR using the GUI difftool:
$ git pr show -t 5859

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5859.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 7, 2021

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2021

@coleenp The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Oct 7, 2021
@coleenp coleenp marked this pull request as ready for review Oct 8, 2021
@openjdk openjdk bot added the rfr label Oct 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 8, 2021

Webrevs

@coleenp
Copy link
Contributor Author

@coleenp coleenp commented Oct 8, 2021

/issue add JDK-8274753
/issue add JDK-8274935

@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2021

@coleenp This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2021

@coleenp
Adding additional issue to issue list: 8274935: dumptime_table has stale entry.

fisk
fisk approved these changes Oct 8, 2021
Copy link
Contributor

@fisk fisk left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2021

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274753: ZGC: SEGV in MetaspaceShared::link_shared_classes
8274935: dumptime_table has stale entry

Reviewed-by: eosterlund, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 36b89a1: 8274785: ciReplay: Potential crash due to uninitialized Compile::_ilt variable
  • 2aacd42: 8274145: C2: condition incorrectly made redundant with dominating main loop exit condition
  • 6364719: 8274004: Change 'nonleaf' rank name
  • b60837a: 8272586: emit abstract machine code in hs-err logs
  • 97ea9dd: 8274840: Update OS detection code to recognize Windows 11
  • 8de7763: 8273152: Refactor CDS FileMapHeader loading code
  • 920e707: 8274920: ProblemList 2 VectorAPI tests failing due to "assert(!vbox->is_Phi()) failed"
  • 7de2cf8: 8273910: Redundant condition and assignment in java.net.URI
  • 8ca0846: 8274407: (tz) Update Timezone Data to 2021c

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 8, 2021
iklam
iklam approved these changes Oct 8, 2021
Copy link
Member

@iklam iklam left a comment

LGTM

@coleenp
Copy link
Contributor Author

@coleenp coleenp commented Oct 8, 2021

Thanks Erik and Ioi!

@coleenp
Copy link
Contributor Author

@coleenp coleenp commented Oct 11, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

Going to push as commit 110e38d.
Since your change was applied there have been 28 commits pushed to the master branch:

  • b7af890: 8274430: Remove some debug error printing code added in JDK-8017163
  • aaf2401: 8274927: Remove unnecessary G1ArchiveAllocator code
  • c55dd36: 8275008: gtest build failure due to stringop-overflow warning with gcc11
  • 3edee1e: 8272723: Don't use Access API to access primitive fields
  • 49f8ce6: 8274773: [TESTBUG] UnsafeIntrinsicsTest intermittently fails on weak memory model platform
  • c032186: 8272968: AArch64: Remove redundant matching rules for commutative ops
  • a05873a: 8274952: jdk/jfr/api/consumer/TestRecordedFrameType.java failed when c1 disabled
  • 5ecc99b: 8274620: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java is timing out
  • 2ff3977: 8275004: CDS build failure with gcc11
  • 296f853: 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/4ab274ac1a241b2d63f46084ec23aa7cff4bc28e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

@coleenp Pushed as commit 110e38d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the cld branch Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
3 participants