JDK-8263155: Allow additional contents for DMG

[andyherrick]

/csr

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8263155: Allow additional contents for DMG

Reviewers

• Alexey Semenyuk (@alexeysemenyukoracle - Reviewer)
• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5912/head:pull/5912
$ git checkout pull/5912

Update a local copy of the PR:
$ git checkout pull/5912
$ git pull https://git.openjdk.java.net/jdk pull/5912/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5912

View PR using the GUI difftool:
$ git pr show -t 5912

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5912.diff

[bridgekeeper]

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@andyherrick The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

@andyherrick this pull request will not be integrated until the CSR request JDK-8275148 for issue JDK-8263155 has been approved.

[mlbridge]

Webrevs

• 01: Full (785c84ef)
• 00: Full (7762da7a)

[andyherrick]

This enhancement adds a command line option "--mac-dmg-content" that can be used to add any other content to a dmg image. The default DMGsetup.scpt is modified to show all the additional content on a second row in Finder (under the application or java runtime and it's install directory).
Changes only ap[ply to dmg type bundles

[mlbridge]

Mailing list message from Michael Hall on core-libs-dev:

+1

[openjdk]

@andyherrick This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263155: Allow additional contents for DMG

Reviewed-by: asemenyuk, almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

• 6a466fe: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields
• 4e9dd4b: 8275384: Change nested classes in jdk.jconsole to static nested classes
• 0961de4: 8275347: ciReplay: staticfield lines not properly terminated
• 7dd8237: 8275084: CDS warning when building with LOG=debug
• 49f9d80: 8243585: AlgorithmChecker::check throws confusing exception when it rejects the signer key
• bef8cf1: 8275714: G1: remove unused variable in G1Policy::transfer_survivors_to_cset
• af14650: 8275569: Add linux-aarch64 to test-make profiles
• 0761a4b: 8275688: Suppress warnings on non-serializable non-transient instance fields in DualPivotQuicksort
• 3cb241a: 8275686: Suppress warnings on non-serializable non-transient instance fields in java.rmi
• 3b0ce23: 8274888: Dump "-DReproduce=true" to the test VM command line output
• ... and 22 more: https://git.openjdk.java.net/jdk/compare/1271fbf3d45ee654faf6e30ffff03c7fb2e5c4a0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[andyherrick]

/integrate

[openjdk]

Going to push as commit b2128a9.
Since your change was applied there have been 35 commits pushed to the master branch:

• 1efe946: 8275712: Hashtable literal_size functions are broken
• fab3d6c: 8275761: Backout: JDK-8274794 Print all owned locks in hs_err file
• c978ca8: 8275344: -Xcheck:jni produces some warnings in the LCMS.c
• 6a466fe: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields
• 4e9dd4b: 8275384: Change nested classes in jdk.jconsole to static nested classes
• 0961de4: 8275347: ciReplay: staticfield lines not properly terminated
• 7dd8237: 8275084: CDS warning when building with LOG=debug
• 49f9d80: 8243585: AlgorithmChecker::check throws confusing exception when it rejects the signer key
• bef8cf1: 8275714: G1: remove unused variable in G1Policy::transfer_survivors_to_cset
• af14650: 8275569: Add linux-aarch64 to test-make profiles
• ... and 25 more: https://git.openjdk.java.net/jdk/compare/1271fbf3d45ee654faf6e30ffff03c7fb2e5c4a0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@andyherrick Pushed as commit b2128a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.