Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8196440: Regression automated Test 'java/awt/TrayIcon/PopupMenuLeakTest/PopupMenuLeakTest.java' fails #6088

Closed
wants to merge 1 commit into from

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Oct 22, 2021

The test doesn't take into account that SystemTray may not be supported.
In case of Ubuntu this happens when _NET_SYSTEM_TRAY is not present.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8196440: Regression automated Test 'java/awt/TrayIcon/PopupMenuLeakTest/PopupMenuLeakTest.java' fails

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6088/head:pull/6088
$ git checkout pull/6088

Update a local copy of the PR:
$ git checkout pull/6088
$ git pull https://git.openjdk.java.net/jdk pull/6088/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6088

View PR using the GUI difftool:
$ git pr show -t 6088

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6088.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 22, 2021

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2021

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label Oct 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 22, 2021

Webrevs

mrserb
mrserb approved these changes Oct 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 23, 2021

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8196440: Regression automated Test 'java/awt/TrayIcon/PopupMenuLeakTest/PopupMenuLeakTest.java' fails

Reviewed-by: serb, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 5dab76b: 8275381: G1: refactor 2 constructors of G1CardSetConfiguration
  • 5bbe4ca: 8275293: A change done with JDK-8268764 mismatches the java.rmi.server.ObjID.hashCode spec
  • c94dc2a: 8272854: split runtime/CommandLine/PrintTouchedMethods.java test
  • fec470f: 8272163: Add -version option to keytool and jarsigner

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 23, 2021
@azvegint
Copy link
Member Author

@azvegint azvegint commented Oct 25, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2021

Going to push as commit f610ef0.
Since your change was applied there have been 9 commits pushed to the master branch:

  • f143d2a: 8268595: java/io/Serializable/serialFilter/GlobalFilterTest.java#id1 failed in timeout
  • 7f94302: 8275511: G1: Rename needs_remset_update to remset_is_tracked in G1HeapRegionAttr
  • 0bcc174: 8275717: Reimplement STATIC_ASSERT to use static_assert
  • f623298: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key
  • 1da5e6b: 8275104: IR framework does not handle client VM builds correctly
  • 5dab76b: 8275381: G1: refactor 2 constructors of G1CardSetConfiguration
  • 5bbe4ca: 8275293: A change done with JDK-8268764 mismatches the java.rmi.server.ObjID.hashCode spec
  • c94dc2a: 8272854: split runtime/CommandLine/PrintTouchedMethods.java test
  • fec470f: 8272163: Add -version option to keytool and jarsigner

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2021

@azvegint Pushed as commit f610ef0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client integrated
3 participants