8255286: Implement ParametersTypeData::print_data_on fully

[shipilev]

There is a little FIXME leftover since JDK 9 build warning fixes. This basically implements ParametersTypeData::print_data_on like SpeculativeTrapData::print_data_on is currently implemented.

Additional testing:

• Linux x86_64 fastdebug tier1

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8255286: Implement ParametersTypeData::print_data_on fully

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6143/head:pull/6143
$ git checkout pull/6143

Update a local copy of the PR:
$ git checkout pull/6143
$ git pull https://git.openjdk.java.net/jdk pull/6143/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6143

View PR using the GUI difftool:
$ git pr show -t 6143

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6143.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (94b2a7de)

[dholmes-ora]

Seems perfectly reasonable.

Thanks,
David

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255286: Implement ParametersTypeData::print_data_on fully

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

• 9a3e954: 8274879: Replace uses of StringBuffer with StringBuilder within java.base classes
• e6fa5fa: 8276063: ProblemList gtest dll_address_to_function_and_library_name on macosx-generic
• 809488b: 8276046: codestrings.validate_vm gtest fails on ppc64, s390
• 93be099: 4718400: Many quantities are held as signed that should be unsigned
• 168081e: 8270490: Charset.forName() taking fallback default value
• a292733: 8275975: Remove dead code in ciInstanceKlass
• 4060602: 8275800: Redefinition leaks MethodData::_extra_data_lock
• 485d658: 8275851: Deproblemlist open/test/jdk/javax/swing/JComponent/6683775/bug6683775.java
• b3f45f8: 8275689: [TESTBUG] Use color tolerance only for XRender in BlitRotateClippedArea test
• 6c05cc9: 8275863: Use encodeASCII for ASCII-compatible DoubleByte encodings
• ... and 33 more: https://git.openjdk.java.net/jdk/compare/f6232982b91cb2314e96ddbde3984836a810a556...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Thanks!

/integrate

[openjdk]

Going to push as commit 6d8fa8f.
Since your change was applied there have been 57 commits pushed to the master branch:

• 63b9f8c: 8153490: Cannot setBytes() if incoming buffer's length is bigger than number of elements we want to insert.
• cb989cf: 8275052: AArch64: Severe AES/GCM slowdown on MacOS for short blocks
• c92f230: 8276110: Problemlist javax/swing/JMenu/4515762/bug4515762.java for macos12
• 309acbf: 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem
• abe52ae: 8275518: accessibility issue in Inet6Address docs
• 85d8cd8: 8276100: Remove G1SegmentedArray constructor name parameter
• a343fa8: 8275865: Print deoptimization statistics in product builds
• bec977c: 8275917: Some locks shouldn't allow_vm_block
• 7c996d5: 8269401: Merge "Exceptions" and "Errors" into "Exception Classes"
• d88b89f: 8276067: ZGC: Remove unused function alloc_high_address_at_most()
• ... and 47 more: https://git.openjdk.java.net/jdk/compare/f6232982b91cb2314e96ddbde3984836a810a556...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 6d8fa8f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.