-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8255266: 2021-11-27 public suffix list update v 3c213aa #6643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8255266: 2021-11-27 public suffix list update v 3c213aa
|
👋 Welcome back weijun! A progress list of the required criteria for merging this PR into |
|
/label remove core-libs |
|
/label remove build |
|
@wangweij |
|
@wangweij |
|
This is not a formal review, but it looks good to me. I verified that the new file matches the one from the referenced upstream commit. I also did a local JDK build with this fix, and then used that in a local test build of FX 8 for JDK-8277734. All passed. |
|
@wangweij This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 78 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Update Public Suffix List data to the latest version at https://github.com/publicsuffix/list.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6643/head:pull/6643$ git checkout pull/6643Update a local copy of the PR:
$ git checkout pull/6643$ git pull https://git.openjdk.java.net/jdk pull/6643/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6643View PR using the GUI difftool:
$ git pr show -t 6643Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6643.diff