Skip to content

Conversation

@wangweij
Copy link
Contributor

@wangweij wangweij commented Dec 1, 2021

Update Public Suffix List data to the latest version at https://github.com/publicsuffix/list.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8255266: 2021-11-27 public suffix list update v 3c213aa

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6643/head:pull/6643
$ git checkout pull/6643

Update a local copy of the PR:
$ git checkout pull/6643
$ git pull https://git.openjdk.java.net/jdk pull/6643/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6643

View PR using the GUI difftool:
$ git pr show -t 6643

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6643.diff

8255266: 2021-11-27 public suffix list update v 3c213aa
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2021

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 1, 2021
@openjdk
Copy link

openjdk bot commented Dec 1, 2021

@wangweij The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Dec 1, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 1, 2021

Webrevs

@wangweij
Copy link
Contributor Author

wangweij commented Dec 1, 2021

/label remove core-libs

@wangweij
Copy link
Contributor Author

wangweij commented Dec 1, 2021

/label remove build

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label Dec 1, 2021
@openjdk
Copy link

openjdk bot commented Dec 1, 2021

@wangweij
The core-libs label was successfully removed.

@openjdk openjdk bot removed the build build-dev@openjdk.org label Dec 1, 2021
@openjdk
Copy link

openjdk bot commented Dec 1, 2021

@wangweij
The build label was successfully removed.

@kevinrushforth
Copy link
Member

This is not a formal review, but it looks good to me. I verified that the new file matches the one from the referenced upstream commit. I also did a local JDK build with this fix, and then used that in a local test build of FX 8 for JDK-8277734. All passed.

@openjdk
Copy link

openjdk bot commented Dec 2, 2021

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255266: 2021-11-27 public suffix list update v 3c213aa

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 78 new commits pushed to the master branch:

  • a729a70: 8225181: KeyStore should have a getAttributes method
  • 38f525e: 8275821: Optimize random number generators developed in JDK-8248862 using Math.unsignedMultiplyHigh()
  • 780b8b1: 8278179: Enable all doclint warnings for build of java.naming
  • 678ac58: 8278240: ProblemList containers/docker/TestJcmd.java on linux-aarch64
  • 01cb2b9: 8277529: SIGSEGV in C2 CompilerThread Node::rematerialize() compiling Packet::readUnsignedTrint
  • 660f21a: 8278119: ProblemList few headful test failing in macosx12-aarch64 system
  • 2e30fa9: 8278171: [vectorapi] Mask incorrectly computed for zero extending cast
  • fbf096e: 8251400: Fix incorrect addition of library to test in JDK-8237858
  • 0a09092: 8268288: jdk/jfr/api/consumer/streaming/TestOutOfProcessMigration.java fails with "Error: ShouldNotReachHere()"
  • 0d938ce: 8278172: java/nio/channels/FileChannel/BlockDeviceSize.java should only run on Linux
  • ... and 68 more: https://git.openjdk.java.net/jdk/compare/7049c13cf4bf4cdfcd0c8f0fa96bf4c3748ae1e7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 2, 2021
@wangweij wangweij marked this pull request as draft December 3, 2021 18:53
@openjdk openjdk bot removed the rfr Pull request is ready for review label Dec 3, 2021
@wangweij wangweij closed this Dec 14, 2021
@wangweij wangweij deleted the 8255266 branch February 17, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants