8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method

[wangweij]

Add check on xpointer(id('name')) format.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6769/head:pull/6769
$ git checkout pull/6769

Update a local copy of the PR:
$ git checkout pull/6769
$ git pull https://git.openjdk.java.net/jdk pull/6769/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6769

View PR using the GUI difftool:
$ git pr show -t 6769

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6769.diff

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ba348fa1)

[seanjmullan]

Can you change the title of the bug to "org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method"

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 130 new commits pushed to the master branch:

• bcb79fd: 8278241: Implement JVM SpinPause on linux-aarch64
• fcebe65: 8278842: Parallel: Remove unused VerifyObjectStartArrayClosure::_old_gen
• 4851ad8: 8278548: G1: Remove unnecessary check in forward_to_block_containing_addr
• 1e3ae3b: 8202579: Revisit VM_Version and VM_Version_ext for overlap and consolidation
• 7adf7f3: 8278351: Add function to retrieve worker_id from any context
• 758fe9b: 8273904: debug agent ArrayTypeImp::newInstance() fails to send reply packet if there is an error
• c442587: 8277619: AArch64: Incorrect parameter type in Advanced SIMD Copy assembler functions
• 46f99ac: 8244765: Undo exclusiveAccess.dirs changes for JDK-8220295 and see if there are still any testing issues
• 54c9a99: 8278643: CoreUtils.getCoreFileLocation() should print out the size of the core file found
• 068a450: 8278825: Unused variable for diagnostic in Resolve
• ... and 120 more: https://git.openjdk.java.net/jdk/compare/2c31a1735d5b8646ed8984a5475d5c8c9c91c19d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[wangweij]

/integrate

[openjdk]

Going to push as commit 1f1db83.
Since your change was applied there have been 130 commits pushed to the master branch:

• bcb79fd: 8278241: Implement JVM SpinPause on linux-aarch64
• fcebe65: 8278842: Parallel: Remove unused VerifyObjectStartArrayClosure::_old_gen
• 4851ad8: 8278548: G1: Remove unnecessary check in forward_to_block_containing_addr
• 1e3ae3b: 8202579: Revisit VM_Version and VM_Version_ext for overlap and consolidation
• 7adf7f3: 8278351: Add function to retrieve worker_id from any context
• 758fe9b: 8273904: debug agent ArrayTypeImp::newInstance() fails to send reply packet if there is an error
• c442587: 8277619: AArch64: Incorrect parameter type in Advanced SIMD Copy assembler functions
• 46f99ac: 8244765: Undo exclusiveAccess.dirs changes for JDK-8220295 and see if there are still any testing issues
• 54c9a99: 8278643: CoreUtils.getCoreFileLocation() should print out the size of the core file found
• 068a450: 8278825: Unused variable for diagnostic in Resolve
• ... and 120 more: https://git.openjdk.java.net/jdk/compare/2c31a1735d5b8646ed8984a5475d5c8c9c91c19d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij Pushed as commit 1f1db83.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.