Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Jan 4, 2022

The real problem is Y2038 (JDK-8279444), which does not look solvable at this time. So for test cleanliness, we might just disable this test on 32-bit platforms.

Additional testing:

  • Linux x86_64 fastdebug, affected test still passes
  • Linux x86_32 fastdebug, affected test is now skipped

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279453: Disable tools/jar/ReproducibleJar.java on 32-bit platforms

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6957/head:pull/6957
$ git checkout pull/6957

Update a local copy of the PR:
$ git checkout pull/6957
$ git pull https://git.openjdk.java.net/jdk pull/6957/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6957

View PR using the GUI difftool:
$ git pr show -t 6957

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6957.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 4, 2022
@openjdk
Copy link

openjdk bot commented Jan 4, 2022

@shipilev The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 4, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 4, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 4, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279453: Disable tools/jar/ReproducibleJar.java on 32-bit platforms

Reviewed-by: alanb, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 191f730: Merge
  • 95a3010: 8275830: C2: Receiver downcast is missing when inlining through method handle linkers
  • 58b5fb3: 8265317: [vector] assert(payload->is_object()) failed: expected 'object' value for scalar-replaced boxed vector but got: NULL
  • 06f3713: 8279379: GHA: Print tests that are in error
  • e7244c1: 8278966: two microbenchmarks tests fail "assert(!jvms->method()->has_exception_handlers()) failed: no exception handler expected" after JDK-8275638
  • b4b0328: 8278824: Uneven work distribution when scanning heap roots in G1
  • 99a8351: 8279386: Remove duplicate RefProcPhaseTimeTracker
  • d1e6f26: 8279351: [TESTBUG] SADebugDTest.java does not handle "Address already in use" error
  • 93c7d90: 8278282: G1: Log basic statistics for evacuation failure
  • 1ffdc52: 8279412: [JVMCI] failed speculations list must outlive any nmethod that refers to it
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/9bdf6eb7b2412ecff523015f1430dfb6a0e4dd09...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 4, 2022
@shipilev
Copy link
Member Author

shipilev commented Jan 5, 2022

Thanks for reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Jan 5, 2022

Going to push as commit a741b92.
Since your change was applied there have been 15 commits pushed to the master branch:

  • b6ec39c: 8279510: Parallel: Remove unused PSScavenge::_consecutive_skipped_scavenges
  • 0f98efb: 8279445: Update JMH devkit to 1.34
  • 8b5de27: 8279485: Incorrect copyright year in compiler/lib/ir_framework/IRNode.java after JDK-8278114
  • f326305: 8278114: New addnode ideal optimization: converting "x + x" into "x << 1"
  • 191f730: Merge
  • 95a3010: 8275830: C2: Receiver downcast is missing when inlining through method handle linkers
  • 58b5fb3: 8265317: [vector] assert(payload->is_object()) failed: expected 'object' value for scalar-replaced boxed vector but got: NULL
  • 06f3713: 8279379: GHA: Print tests that are in error
  • e7244c1: 8278966: two microbenchmarks tests fail "assert(!jvms->method()->has_exception_handlers()) failed: no exception handler expected" after JDK-8275638
  • b4b0328: 8278824: Uneven work distribution when scanning heap roots in G1
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/9bdf6eb7b2412ecff523015f1430dfb6a0e4dd09...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 5, 2022
@openjdk openjdk bot closed this Jan 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@shipilev Pushed as commit a741b92.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8279453-disable-reprod-jars branch January 27, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants