Skip to content

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Feb 4, 2022

See the discussion in the bug. This realistically affects only Serial and Parallel. My first attempt was to push through initial_size to generations properly, but it is too intrusive to my liking. The current patch "just" caps the initial to max.

Additional testing:

  • New regression test now passes on all GCs
  • Linux x86_64 hotspot:tier1

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8281254: GCs with survivor spaces report Init > Max through MXBeans

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7341/head:pull/7341
$ git checkout pull/7341

Update a local copy of the PR:
$ git checkout pull/7341
$ git pull https://git.openjdk.java.net/jdk pull/7341/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7341

View PR using the GUI difftool:
$ git pr show -t 7341

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7341.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 4, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 4, 2022
@openjdk
Copy link

openjdk bot commented Feb 4, 2022

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Feb 4, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 4, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2022

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@shipilev
Copy link
Member Author

shipilev commented Mar 7, 2022

Not yet, bot.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2022

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@shipilev
Copy link
Member Author

Any opinions about this?

@bridgekeeper
Copy link

bridgekeeper bot commented May 26, 2022

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 23, 2022

@shipilev This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants