-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8282936: Write a regression test for JSplitPane divider location #7802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back mvs! A progress list of the required criteria for merging this PR into |
@manukumarvs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
test/jdk/javax/swing/JSplitPane/4615365/JSplitPaneDividerLocationTest.java
Outdated
Show resolved
Hide resolved
@mrserb I have fixed the review comments, can you please have a look. |
@manukumarvs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 401 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@manukumarvs |
/sponsor |
Going to push as commit c3d903a.
Your commit was automatically rebased without conflicts. |
@akolarkunnu @manukumarvs Pushed as commit c3d903a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Write a regression test for JDK-4615365 : JSplitPane current and last divider positions incorrect when realized
Issue:
JSplitPane component with a left and right component has its current divider
position incorrectly set to -1 once it is fully realized. For JDK 1.3.1, its
value is set to 0. The current position of the divider should be the current
position of the divider once layout management is complete. If the divider is
moved one pixel, the current divider position is updated to the correct value
but the last divider position is then set to -1 (i.e. the last value of the
current divider position). If the divider is moved again, everything is OK.
Testing:
Java 1.4.0 -> Test Failed.
$ j2sdk1.4.0/bin/java bug4615365
current= -1, last= 0
Test Failed.
Java 1.4.1 -> Test Passed.
$ j2sdk1.4.1/bin/java bug4615365
current= 97, last= -1
Test Passed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7802/head:pull/7802
$ git checkout pull/7802
Update a local copy of the PR:
$ git checkout pull/7802
$ git pull https://git.openjdk.java.net/jdk pull/7802/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7802
View PR using the GUI difftool:
$ git pr show -t 7802
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7802.diff