Skip to content

Conversation

manukumarvs
Copy link
Member

@manukumarvs manukumarvs commented Mar 13, 2022

Write a regression test for JDK-4615365 : JSplitPane current and last divider positions incorrect when realized

Issue:
JSplitPane component with a left and right component has its current divider
position incorrectly set to -1 once it is fully realized. For JDK 1.3.1, its
value is set to 0. The current position of the divider should be the current
position of the divider once layout management is complete. If the divider is
moved one pixel, the current divider position is updated to the correct value
but the last divider position is then set to -1 (i.e. the last value of the
current divider position). If the divider is moved again, everything is OK.

Testing:
Java 1.4.0 -> Test Failed.
$ j2sdk1.4.0/bin/java bug4615365
current= -1, last= 0
Test Failed.

Java 1.4.1 -> Test Passed.
$ j2sdk1.4.1/bin/java bug4615365
current= 97, last= -1
Test Passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7802/head:pull/7802
$ git checkout pull/7802

Update a local copy of the PR:
$ git checkout pull/7802
$ git pull https://git.openjdk.java.net/jdk pull/7802/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7802

View PR using the GUI difftool:
$ git pr show -t 7802

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7802.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2022

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 13, 2022
@openjdk
Copy link

openjdk bot commented Mar 13, 2022

@manukumarvs The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 13, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 13, 2022

Webrevs

@manukumarvs
Copy link
Member Author

@mrserb I have fixed the review comments, can you please have a look.

@openjdk
Copy link

openjdk bot commented Mar 24, 2022

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282936: Write a regression test for JDK-4615365

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 401 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 24, 2022
@manukumarvs
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 24, 2022
@openjdk
Copy link

openjdk bot commented Mar 24, 2022

@manukumarvs
Your change (at version 9e810ad) is now ready to be sponsored by a Committer.

@akolarkunnu
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 29, 2022

Going to push as commit c3d903a.
Since your change was applied there have been 454 commits pushed to the master branch:

  • cc598e0: 8283774: TestZoneOffset::test_immutable should ignore ZoneOffset::rules
  • 0e788e0: 8283781: Avoid allocating unused lastRulesCaches
  • 043b0a7: 8273355: Flickering on tooltip appearance IntelliJ IDEA 2021.2.1
  • 2367228: 8283834: Unmappable character for US-ASCII encoding in TestPredicateInputBelowLoopPredicate
  • 2e9fd56: 8283670: gtest os.release_multi_mappings_vm is still racy
  • f01cce2: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS
  • 634800a: 8283806: [BACKOUT] JDK 19 L10n resource files update - msgdrop 10
  • 9b49900: 8283603: Remove redundant qualifier in Windows specific Attach Operation
  • d8fd222: 8282538: PKCS11 tests fail on CentOS Stream 9
  • d472c01: 8283711: Remove redundant 'new String' calls after concatenation
  • ... and 444 more: https://git.openjdk.java.net/jdk/compare/f07b8165231799383303e5c0755d07afd2feb7fd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 29, 2022
@openjdk openjdk bot closed this Mar 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 29, 2022
@openjdk
Copy link

openjdk bot commented Mar 29, 2022

@akolarkunnu @manukumarvs Pushed as commit c3d903a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@manukumarvs manukumarvs deleted the 8282936 branch May 4, 2022 07:49
@manukumarvs manukumarvs changed the title 8282936: Write a regression test for JDK-4615365 8282936: Write a regression test for JSplitPane divider location Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants