-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8283703: Add sealed modifier to java.awt.geom.Path2D #8048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
|
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 51 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 86caf60.
Your commit was automatically rebased without conflicts. |
JDK 17 delivered JEP 409: Sealed Classes : https://openjdk.java.net/jeps/409
In essence this JEP allows a class to limit which classes can subclass it.
Path2D can be sealed because no code outside the package can sub-class it directly.
However the extant subclasses need to be made non-sealed as they can be sub-classed.
jtreg tests and JCK API tests pass.
CSR here : https://bugs.openjdk.java.net/browse/JDK-8284031
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8048/head:pull/8048$ git checkout pull/8048Update a local copy of the PR:
$ git checkout pull/8048$ git pull https://git.openjdk.java.net/jdk pull/8048/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8048View PR using the GUI difftool:
$ git pr show -t 8048Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8048.diff