Skip to content

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Mar 30, 2022

JDK 17 delivered JEP 409: Sealed Classes : https://openjdk.java.net/jeps/409
In essence this JEP allows a class to limit which classes can subclass it.

Path2D can be sealed because no code outside the package can sub-class it directly.

However the extant subclasses need to be made non-sealed as they can be sub-classed.

jtreg tests and JCK API tests pass.

CSR here : https://bugs.openjdk.java.net/browse/JDK-8284031


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
  • Change requires a CSR request to be approved

Issues

  • JDK-8283703: Add sealed modifier to java.awt.geom.Path2D
  • JDK-8284031: Add sealed modifier to java.awt.geom.Path2D (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8048/head:pull/8048
$ git checkout pull/8048

Update a local copy of the PR:
$ git checkout pull/8048
$ git pull https://git.openjdk.java.net/jdk pull/8048/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8048

View PR using the GUI difftool:
$ git pr show -t 8048

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8048.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 30, 2022

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 30, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 30, 2022

Webrevs

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Mar 30, 2022
@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Apr 4, 2022
@openjdk
Copy link

openjdk bot commented Apr 4, 2022

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283703: Add sealed modifier to java.awt.geom.Path2D

Reviewed-by: bpb, kizune, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

  • 36b9baa: 8282508: Updating ASM to 9.2 for JDK 19
  • 4e20a03: 8283044: Use asynchronous handshakes to deliver asynchronous exceptions
  • 9d200d6: 8282756: Make ElementKind checks more specific
  • 1012d59: 8281079: [s390] Unify Address Operand Encoding in Instruction Emitters
  • 003ec21: 8279508: Auto-vectorize Math.round API
  • c1e67b6: 8283474: Include detailed heap object info in CDS map file
  • 060a188: 8283865: riscv: Break down -XX:+UseRVB into seperate options for each bitmanip extension
  • e5e1aab: 8284068: riscv: should call Atomic::release_store in JavaThread::set_thread_state
  • 0b09f70: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368
  • afd0f5a: 8284190: disable G1RegionToSpaceMapper.largeStressAdjacent_vm on windows
  • ... and 41 more: https://git.openjdk.java.net/jdk/compare/e85fa2f04b17531862c2469597674d60ad25a19f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 4, 2022
@prrace
Copy link
Contributor Author

prrace commented Apr 4, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 4, 2022

Going to push as commit 86caf60.
Since your change was applied there have been 57 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2022
@openjdk openjdk bot closed this Apr 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 4, 2022
@openjdk
Copy link

openjdk bot commented Apr 4, 2022

@prrace Pushed as commit 86caf60.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants