8285011: gc/arguments/TestUseCompressedOopsFlagsWithUlimit.java fails after JDK-8280761

[tschatzl]

Hi all,

can I get reviews for this little test fix that avoids running that test with collectors/platforms where either compressed oops are not supported (ZGC) or the ulimit -v call isn't (OSX)?

Testing: tier1, gha

Thanks,
Thomas

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8285011: gc/arguments/TestUseCompressedOopsFlagsWithUlimit.java fails after JDK-8280761

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Leo Korinth (@lkorinth - Reviewer)

Contributors

• Albert Mingkun Yang <ayang@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8401/head:pull/8401
$ git checkout pull/8401

Update a local copy of the PR:
$ git checkout pull/8401
$ git pull https://git.openjdk.java.net/jdk pull/8401/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8401

View PR using the GUI difftool:
$ git pr show -t 8401

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8401.diff

[tschatzl]

/contributor add @albertnetymk

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl
Contributor Albert Mingkun Yang <ayang@openjdk.org> successfully added.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9327f5d5)

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285011: gc/arguments/TestUseCompressedOopsFlagsWithUlimit.java fails after JDK-8280761

Co-authored-by: Albert Mingkun Yang <ayang@openjdk.org>
Reviewed-by: ayang, lkorinth

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

• 2d8d140: 8285690: CloneableReference subtest should not throw CloneNotSupportedException
• ea83b44: 8280510: AArch64: Vectorize operations with loop induction variable
• 36bf6fb: 8285728: Alpine Linux build fails with busybox tar
• 091637c: 8285630: Fix a configure error in RISC-V cross build
• ccf0e8b: 8285755: JDK-8285093 changed the default for --with-output-sync
• d7514b0: 8285595: Assert frame anchor doesn't change in safepoints/handshakes
• 5629c75: 8284848: C2: Compiler blackhole arguments should be treated as globally escaping
• 85f8d14: 8283994: Make Xerces DatatypeException stackless
• 4f2e4c7: 8178969: [TESTBUG] Wrong reporting of gc/g1/humongousObjects/TestHeapCounters test.
• 4795165: 8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null
• ... and 35 more: https://git.openjdk.java.net/jdk/compare/67755edd6ff2e2eeafafec207d0459bca53f882b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lkorinth]

Looks good to me.

[tschatzl]

Thanks @lkorinth @albertnetymk for your reviews.

/integrate

[openjdk]

Going to push as commit b718578.
Since your change was applied there have been 45 commits pushed to the master branch:

• 2d8d140: 8285690: CloneableReference subtest should not throw CloneNotSupportedException
• ea83b44: 8280510: AArch64: Vectorize operations with loop induction variable
• 36bf6fb: 8285728: Alpine Linux build fails with busybox tar
• 091637c: 8285630: Fix a configure error in RISC-V cross build
• ccf0e8b: 8285755: JDK-8285093 changed the default for --with-output-sync
• d7514b0: 8285595: Assert frame anchor doesn't change in safepoints/handshakes
• 5629c75: 8284848: C2: Compiler blackhole arguments should be treated as globally escaping
• 85f8d14: 8283994: Make Xerces DatatypeException stackless
• 4f2e4c7: 8178969: [TESTBUG] Wrong reporting of gc/g1/humongousObjects/TestHeapCounters test.
• 4795165: 8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null
• ... and 35 more: https://git.openjdk.java.net/jdk/compare/67755edd6ff2e2eeafafec207d0459bca53f882b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit b718578.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.