8285951: Replace Algorithms.eatMemory(...) with WB.fullGC() in vmTestbase_vm_gc_ref tests

[lmesnik]

remainging weak/soft/phantom reference tests are updated to use WB.fullGC()

The TEST.properties are removed for single-threaded tests.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8285951: Replace Algorithms.eatMemory(...) with WB.fullGC() in vmTestbase_vm_gc_ref tests

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8474/head:pull/8474
$ git checkout pull/8474

Update a local copy of the PR:
$ git checkout pull/8474
$ git pull https://git.openjdk.java.net/jdk pull/8474/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8474

View PR using the GUI difftool:
$ git pr show -t 8474

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8474.diff

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (c109fff4)
• 01: Full - Incremental (b49e2415)
• 00: Full (bffb295b)

[kimbarrett]

Looks good.

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285951: Replace Algorithms.eatMemory(...) with WB.fullGC() in vmTestbase_vm_gc_ref tests

Reviewed-by: kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 186 new commits pushed to the master branch:

• 7118343: 8278262: JFR: TestPrintXML can't handle missing timestamps
• 74eee28: 8286560: Remove user parameter from jdk.internal.perf.Perf.attach()
• 160944b: 8286615: Small refactor to SerializedLambda
• 17c5278: 8286378: Address possibly lossy conversions in java.base
• 0a6832b: 8286617: Improve parameter names in javax.lang.model utility visitors
• 2c5d136: 8282191: Implementation of Foreign Function & Memory API (Preview)
• 3be394e: 8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked
• cc7560e: 8286287: Reading file as UTF-16 causes Error which "shouldn't happen"
• 82aa045: 8286015: JFR: Remove jfr.save.generated.asm
• 1904e9d: 8286423: Destroy password protection in the example code in KeyStore
• ... and 176 more: https://git.openjdk.java.net/jdk/compare/2dd882af0830f174810840affa79045db4f04ef0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Seems good. It seems that with this change we can close out all existing issues with these tests (phantom*, soft*, etc) that fail because of intermittent OOME.

[kimbarrett]

Still looks good.

[lmesnik]

/integrate

[openjdk]

Going to push as commit 61cb4b7.
Since your change was applied there have been 187 commits pushed to the master branch:

• 5ff1d22: 8286386: Address possibly lossy conversions in java.net.http
• 7118343: 8278262: JFR: TestPrintXML can't handle missing timestamps
• 74eee28: 8286560: Remove user parameter from jdk.internal.perf.Perf.attach()
• 160944b: 8286615: Small refactor to SerializedLambda
• 17c5278: 8286378: Address possibly lossy conversions in java.base
• 0a6832b: 8286617: Improve parameter names in javax.lang.model utility visitors
• 2c5d136: 8282191: Implementation of Foreign Function & Memory API (Preview)
• 3be394e: 8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked
• cc7560e: 8286287: Reading file as UTF-16 causes Error which "shouldn't happen"
• 82aa045: 8286015: JFR: Remove jfr.save.generated.asm
• ... and 177 more: https://git.openjdk.java.net/jdk/compare/2dd882af0830f174810840affa79045db4f04ef0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik Pushed as commit 61cb4b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.