Skip to content

Conversation

@asotona
Copy link
Member

@asotona asotona commented May 4, 2022

Man file for the java command in JDK, the arguments such as -classpath, --module-path and --upgrade-module-path say "A semicolon (;) separated list of directories"

Please review this fix correcting the text to "A colon (:) separated list of directories".

Thanks,
Adam


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8262004: Classpath separator: Man page says semicolon; should be colon on Linux

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8530/head:pull/8530
$ git checkout pull/8530

Update a local copy of the PR:
$ git checkout pull/8530
$ git pull https://git.openjdk.java.net/jdk pull/8530/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8530

View PR using the GUI difftool:
$ git pr show -t 8530

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8530.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 4, 2022

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8262004: Classpath separator: Man page says semicolon; should be colon 8262004: Classpath separator: Man page says semicolon; should be colon on Linux May 4, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label May 4, 2022
@openjdk
Copy link

openjdk bot commented May 4, 2022

@asotona To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@asotona
Copy link
Member Author

asotona commented May 4, 2022

/label add hotspot-runtime

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 4, 2022
@openjdk
Copy link

openjdk bot commented May 4, 2022

@asotona
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

mlbridge bot commented May 4, 2022

Webrevs

@dholmes-ora
Copy link
Member

Hi @asotona,
The actual source for this is in our closed repository and while this is a manpage and arguably non-Windows, the actual source produces other output variations that are platform agnostic. So we actually need to fix this at a higher-level and clarify that the path separator is actually platform specific.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Thanks.

@openjdk
Copy link

openjdk bot commented May 5, 2022

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262004: Classpath separator: Man page says semicolon; should be colon on Linux

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • 6d7e446: 8283306: re-resolving indirect call to non-entrant nmethod can crash
  • 4957bc7: 8286056: AArch64: clarify uses of MacroAssembler::far_call/MacroAssembler::far_jump
  • e7adc28: 8284675: "jpackage.exe" creates application launcher without Windows Application Manfiest
  • 9644a31: 8285616: [macos] Incorrect path for launcher-as-service.txt in .cfg file
  • 2f995c8: 8286199: ProblemList jdk/jshell/ExternalEditorTest.java
  • 2293448: 8272352: Java launcher can not parse Chinese character when system locale is set to UTF-8
  • 1bba640: 8284027: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/ is failing
  • 5ac7186: 8282559: Allow multiple search terms in javadoc search
  • 7022543: 8286195: ProblemList test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
  • ede06c3: 8282060: RemoteRuntimeImageTest is not actually testing on JDK 8
  • ... and 26 more: https://git.openjdk.java.net/jdk/compare/0462d5a25258458ec7f40d76b9d910ee529f3647...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 5, 2022
@asotona
Copy link
Member Author

asotona commented May 6, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 6, 2022

Going to push as commit 015cfda.
Since your change was applied there have been 40 commits pushed to the master branch:

  • 9425ab2: 8286153: Remove redundant casts and other cleanup
  • 7ebc4bc: 8286066: assert(k != __null) failed: klass not loaded caused by FillerObject_klass
  • 6a1b145: 8286029: Add classpath exemption to globals_vectorApiSupport_***.S.inc
  • 59ef76a: 8285497: Add system property for Java SE specification maintenance version
  • 6d7e446: 8283306: re-resolving indirect call to non-entrant nmethod can crash
  • 4957bc7: 8286056: AArch64: clarify uses of MacroAssembler::far_call/MacroAssembler::far_jump
  • e7adc28: 8284675: "jpackage.exe" creates application launcher without Windows Application Manfiest
  • 9644a31: 8285616: [macos] Incorrect path for launcher-as-service.txt in .cfg file
  • 2f995c8: 8286199: ProblemList jdk/jshell/ExternalEditorTest.java
  • 2293448: 8272352: Java launcher can not parse Chinese character when system locale is set to UTF-8
  • ... and 30 more: https://git.openjdk.java.net/jdk/compare/0462d5a25258458ec7f40d76b9d910ee529f3647...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 6, 2022
@openjdk openjdk bot closed this May 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 6, 2022
@openjdk
Copy link

openjdk bot commented May 6, 2022

@asotona Pushed as commit 015cfda.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants