Skip to content

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented May 9, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8282351: jpackage does not work if class file has $$ in the name on windows

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8613/head:pull/8613
$ git checkout pull/8613

Update a local copy of the PR:
$ git checkout pull/8613
$ git pull https://git.openjdk.java.net/jdk pull/8613/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8613

View PR using the GUI difftool:
$ git pr show -t 8613

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8613.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2022

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 9, 2022

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review labels May 9, 2022
@mlbridge
Copy link

mlbridge bot commented May 9, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 9, 2022

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282351: jpackage does not work if class file has `$$` in the name on windows

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • 61450bb: 8283651: nsk/jvmti/SuspendThread/suspendthrd003 may leak native memory
  • c28a636: 8286442: ProblemList compiler/c2/irTests/TestSkeletonPredicates.java in -Xcomp mode
  • 54e3308: 8286348: incorrect use of @serial
  • b0d2b0a: 8286331: jni_GetStringUTFChars() uses wrong heap allocator
  • 902b1dd: 8284686: Interval of < 1 ms disables ExecutionSample events
  • 02e5fc0: 8286435: JDK-8284316 caused validate-source to fail in Tier1
  • 6a7c023: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests
  • 40470d8: 8284550: test failure_handler is not properly invoking jhsdb jstack, resulting in failure to produce a stack when a test times out
  • 837928b: 8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"
  • 397d095: 8285743: Ensure each IntegerPolynomial object is only created once
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/080f3c5d8a2f7b2d13baf98c594d4ace67608fc4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 9, 2022
@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 10, 2022

Going to push as commit 2939553.
Since your change was applied there have been 29 commits pushed to the master branch:

  • 61450bb: 8283651: nsk/jvmti/SuspendThread/suspendthrd003 may leak native memory
  • c28a636: 8286442: ProblemList compiler/c2/irTests/TestSkeletonPredicates.java in -Xcomp mode
  • 54e3308: 8286348: incorrect use of @serial
  • b0d2b0a: 8286331: jni_GetStringUTFChars() uses wrong heap allocator
  • 902b1dd: 8284686: Interval of < 1 ms disables ExecutionSample events
  • 02e5fc0: 8286435: JDK-8284316 caused validate-source to fail in Tier1
  • 6a7c023: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests
  • 40470d8: 8284550: test failure_handler is not properly invoking jhsdb jstack, resulting in failure to produce a stack when a test times out
  • 837928b: 8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"
  • 397d095: 8285743: Ensure each IntegerPolynomial object is only created once
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/080f3c5d8a2f7b2d13baf98c594d4ace67608fc4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 10, 2022
@openjdk openjdk bot closed this May 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 10, 2022
@openjdk
Copy link

openjdk bot commented May 10, 2022

@alexeysemenyukoracle Pushed as commit 2939553.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants