8286681: ShenandoahControlThread::request_gc misses the case of GCCause::_codecache_GC_threshold #8691

DamonFool · 2022-05-13T02:43:55Z

Hi all,

Some tests fail with Shenandoah GC after JDK-8282191.
The reason is that the assert in ShenandoahControlThread::request_gc misses the case of GCCause::_codecache_GC_threshold.
It would be better to fix it.

Thanks.
Best regards,
Jie

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

JDK-8286681: ShenandoahControlThread::request_gc misses the case of GCCause::_codecache_GC_threshold

Reviewers

Zhengyu Gu (@zhengyu123 - Reviewer) ⚠️ Review applies to 8f094d32

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8691/head:pull/8691
$ git checkout pull/8691

Update a local copy of the PR:
$ git checkout pull/8691
$ git pull https://git.openjdk.java.net/jdk pull/8691/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8691

View PR using the GUI difftool:
$ git pr show -t 8691

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8691.diff

…cache_GC_threshold

bridgekeeper · 2022-05-13T02:45:11Z

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-05-13T02:47:15Z

@DamonFool The following labels will be automatically applied to this pull request:

core-libs
hotspot-gc
shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-05-13T02:54:22Z

Webrevs

01: Full - Incremental (dc96246c)
00: Full (8f094d32)

AlanBateman · 2022-05-13T06:36:42Z

test/jdk/java/foreign/TestIntrinsics.java

+ *   -Xbatch
+ *   -XX:+UseShenandoahGC
+ *   TestIntrinsics
+ */


Is this needed? The parameters looks the same as the first test description so if you are testing with +ShenandoahGC then it will run already.

Without -XX:+UseShenandoahGC, this bug wouldn't be exposed.

What do you mean by if you are testing with +ShenandoahGC then it will run already?

I assume you are running the tests with:
make run-tests TEST_OPTS_JAVA_OPTIONS="-XX:+UseShenandoahGC"
in which case, all of the tests you select to run will be run with that GC.

What you have is not wrong but wouldn't be a better to add a new test to test/hotspot/jtreg/gc rather than relying on test in test/jdk/java/foreign?

I assume you are running the tests with: make run-tests TEST_OPTS_JAVA_OPTIONS="-XX:+UseShenandoahGC" in which case, all of the tests you select to run will be run with that GC.

Yes, you're right.

What you have is not wrong but wouldn't be a better to add a new test to test/hotspot/jtreg/gc rather than relying on test in test/jdk/java/foreign?

I would suggest reusing the existing test in java/foreign.
This is because this bug was first triggered after Implementation of Foreign Function & Memory API (Preview) integration.
And I don't want a copy-paste code duplication in a new test file.
Thanks.

I think I agree with @AlanBateman - in the sense that this seems to go down a slippery slope where every test would need to be executed against all possible GCs. AFAIK, there are no other foreign tests doing this.

I think I agree with @AlanBateman - in the sense that this seems to go down a slippery slope where every test would need to be executed against all possible GCs. AFAIK, there are no other foreign tests doing this.

I think it's a waste of time to write a separate test for this bug.

I can't understand why you are against adding one more test config in the foreign test.
Yes, it caught the bug in ShenandoahGC but who knows it wouldn't find some other bugs in the foreign api in the future.
If you are still against the newly added test config, I can revert the test change.
Thanks.

My comment seems to have never made it through. The problem with what your are doing is two-fold:

When running the test suite specifically to test xGC for whatever x you are now forcing a test run for Shenandoah.

When x is Shenandoah then you run this test twice.

You don't need a config just to run this with Shenandoah - you run the test suite with Shenandoah.

The test change had been reverted.
Thanks.

zhengyu123

LGTM

openjdk · 2022-05-13T12:28:35Z

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286681: ShenandoahControlThread::request_gc misses the case of GCCause::_codecache_GC_threshold

Reviewed-by: zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

cbe7e7b: 8284956: Potential leak awtImageData/color_data when initializes X11GraphicsEnvironment
8daf08d: 8286628: Remove unused BufferNode::Allocator::flush_free_list
04df8b7: 8286194: ExecutorShutdown test fails intermittently
0be1f3e: 8286689: (se) Adjusting to select timeout after EINTR messed up after JDK-8286378
6a1b098: 8278039: Code completion not woking after some statements such as "if" or "while"
11fa03f: 8282160: JShell circularly-required classes cannot be defined
d5ae383: 8286117: Remove unnecessary indirection and unused code in UL

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

DamonFool · 2022-05-14T10:12:20Z

LGTM

Thanks @zhengyu123 for the review.
/integrate

openjdk · 2022-05-14T10:14:00Z

Going to push as commit 9eb15c9.
Since your change was applied there have been 16 commits pushed to the master branch:

e4378ab: 8286559: Re-examine synchronization of mark and reset methods on InflaterInputStream
f56396f: 6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows
273c732: 8277493: [REDO] Quarantined jpackage apps are labeled as "damaged"
583a61a: 8286671: (fc) Modify sun.nio.ch.FileChannelImpl.map0() to accept a FileDescriptor parameter
1e843c3: 8286604: Update InputStream and OutputStream to use @implSpec
78ffefb: 8286668: JFR: Cleanup
76caeed: 8285366: Fix typos in serviceability
f631c98: 8285380: Fix typos in security
237f280: 8286393: Address possibly lossy conversions in java.rmi
cbe7e7b: 8284956: Potential leak awtImageData/color_data when initializes X11GraphicsEnvironment
... and 6 more: https://git.openjdk.java.net/jdk/compare/c3bade2e08f865bf1e65d48e6d27bff9c022d35f...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-05-14T10:14:19Z

@DamonFool Pushed as commit 9eb15c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

ShenandoahControlThread::request_gc misses the case of GCCause::_code…

8f094d3

…cache_GC_threshold

openjdk bot added core-libs core-libs-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels May 13, 2022

DamonFool changed the title ~~ShenandoahControlThread::request_gc misses the case of GCCause::_codecache_GC_threshold~~ 8286681: ShenandoahControlThread::request_gc misses the case of GCCause::_codecache_GC_threshold May 13, 2022

openjdk bot added the rfr Pull request is ready for review label May 13, 2022

AlanBateman reviewed May 13, 2022

View reviewed changes

zhengyu123 approved these changes May 13, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label May 13, 2022

Revert the test change

dc96246

openjdk bot added the integrated Pull request has been integrated label May 14, 2022

openjdk bot closed this May 14, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 14, 2022

DamonFool deleted the JDK-8286681 branch May 14, 2022 10:14

8286681: ShenandoahControlThread::request_gc misses the case of GCCause::_codecache_GC_threshold #8691

8286681: ShenandoahControlThread::request_gc misses the case of GCCause::_codecache_GC_threshold #8691

Uh oh!

Conversation

DamonFool commented May 13, 2022 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented May 13, 2022

Uh oh!

openjdk bot commented May 13, 2022

Uh oh!

mlbridge bot commented May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhengyu123 left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DamonFool commented May 14, 2022

Uh oh!

openjdk bot commented May 14, 2022

Uh oh!

openjdk bot commented May 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

DamonFool commented May 13, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented May 13, 2022 •

edited

Loading

openjdk bot commented May 13, 2022 •

edited

Loading