Skip to content

Conversation

@cl4es
Copy link
Member

@cl4es cl4es commented Jun 16, 2022

Reduce runtime by reducing number of forks, iterations..

Most benchmarks in the java.nio packages already had sensible configuration, so this reduces estimated runtime by a small amount (~5h42m -> ~5s03m)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287905: Reduce runtime of java.nio microbenchmarks

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9183/head:pull/9183
$ git checkout pull/9183

Update a local copy of the PR:
$ git checkout pull/9183
$ git pull https://git.openjdk.org/jdk pull/9183/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9183

View PR using the GUI difftool:
$ git pr show -t 9183

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9183.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2022

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 16, 2022
@openjdk
Copy link

openjdk bot commented Jun 16, 2022

@cl4es The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Jun 16, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 16, 2022

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287905: Reduce runtime of java.nio microbenchmarks

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 16, 2022
@cl4es
Copy link
Member Author

cl4es commented Jun 16, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 16, 2022

Going to push as commit 8fc8fdc.
Since your change was applied there have been 12 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 16, 2022
@openjdk openjdk bot closed this Jun 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 16, 2022
@openjdk
Copy link

openjdk bot commented Jun 16, 2022

@cl4es Pushed as commit 8fc8fdc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated nio nio-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants