8255562: delete UseRDPCForConstantTableBase #949

navyxliu · 2020-10-30T05:43:25Z

UseRDPCForConstantTableBase was a SPARC-exclusive flag. Sparc has been removed
from hotspot, so remove this flag.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Testing

	Linux x64	Linux x86	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

JDK-8255562: delete UseRDPCForConstantTableBase

Reviewers

Volker Simonis (@simonis - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/949/head:pull/949
$ git checkout pull/949

bridgekeeper · 2020-10-30T05:44:01Z

👋 Welcome back xliu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2020-10-30T05:45:36Z

@navyxliu The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2020-10-30T05:51:49Z

Webrevs

03: Full - Incremental (213a161)
02: Full - Incremental (ae68617)
01: Full - Incremental (478aab950bebf0d60ee050a05b738ee9afbddc7c)
00: Full (a4e875e82ec87f1c6a8c6a825daac72b1ee2a6d9)

vidmik · 2020-10-30T06:18:51Z

/csr needed

openjdk · 2020-10-30T06:20:50Z

@vidmik has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@navyxliu please create a CSR request and add link to it in JDK-8255562. This pull request cannot be integrated until the CSR request is approved.

src/hotspot/share/opto/machnode.hpp

mark UseRDPCForConstantTableBase is obsoletd in jdk16 and will expire in jdk17.

navyxliu · 2020-11-05T06:00:52Z

I made the hotspot cmdline flag UseRDPCForConstantTableBase obsolete in jdk(16) and will expire in jdk(17) based on the document here

The reason I modified Arguments::handle_aliases_and_deprecation is that hotspot didn't emit any warning message if we only mark it obsoleted but never define deprecated version. After I modify it, it emits a warning message to alarm user that the flag has been obsoleted.

./bin/java -XX:+UseRDPCForConstantTableBase --version
OpenJDK 64-Bit Server VM warning: Temporarily processing option UseRDPCForConstantTableBase; support is scheduled for removal in 16.0
openjdk 16-internal 2021-03-16
OpenJDK Runtime Environment (build 16-internal+0-adhoc.ubuntu.jdk)
OpenJDK 64-Bit Server VM (build 16-internal+0-adhoc.ubuntu.jdk, mixed mode)

simonis

Hi Xin,
you also have to remove the option from c2_globals.hpp. Also, please add the line

{ "UseRDPCForConstantTableBase",  JDK_Version::undefined(), JDK_Version::jdk(16), JDK_Version::jdk(17) },

unconditionally (e.g. after the line for the Debugging option). You've added it to the #ifndef COMPILER2 section. I suppose that's the reason why you haven't seen the deprecation warning.

I think if you add the option unconditionally to special_jvm_flags you shouldn't need any changes to Arguments::handle_aliases_and_deprecation.

You can have a look at 8252889: Obsolete -XX:+InsertMemBarAfterArraycopy for an example.

revert the change of Arguments::handle_aliases_and_deprecation. Arguments::process_argument can handle obsoleted arguments.

simonis

Thnaks Xin. Looks good to me now.

navyxliu · 2020-11-06T18:15:32Z

@simonis Thanks!
/integrate

openjdk · 2020-11-06T18:15:41Z

@navyxliu This PR has not yet been marked as ready for integration.

simonis · 2020-11-06T18:19:43Z

@navyxliu , you can't push this before the CSR has not been approved.

openjdk · 2020-11-07T01:36:09Z

@navyxliu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255562: delete UseRDPCForConstantTableBase

Reviewed-by: simonis

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

c5462bb: 8255989: Remove explicitly unascribed authorship from Java source files
358f5d2: 6422025: ThemeReader.cpp can be updated for VC7
a9dff94: 8254864: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java timed out
0b7fba7: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c
f5d36e6: 8246741: NetworkInterface/UniqueMacAddressesTest: mac address uniqueness test failed
688b10b: 8255561: add tests to check binary compatibility rules for records
727a69f: 8255969: Improve java/io/BufferedInputStream/LargeCopyWithMark.java using jtreg tags
952abea: 8254920: Application launched with jpackage produced .exe crashes JVM
5dfb42f: 8255563: Missing NULL checks after JDK-8233624
e730e8b: 8241806: The sun/awt/shell/FileSystemViewMemoryLeak.java is unstable
... and 22 more: https://git.openjdk.java.net/jdk/compare/397bae20e9e6ae91a7d3ee74460e0e3c9da572f9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @simonis) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

phohensee · 2020-11-07T20:29:23Z

/sponsor

openjdk · 2020-11-07T20:29:38Z

@phohensee The change author (@navyxliu) must issue an integrate command before the integration can be sponsored.

navyxliu · 2020-11-07T22:14:18Z

/integrate

openjdk · 2020-11-07T22:15:00Z

@navyxliu
Your change (at version 213a161) is now ready to be sponsored by a Committer.

phohensee · 2020-11-08T15:03:22Z

/sponsor

openjdk · 2020-11-08T15:04:12Z

@phohensee @navyxliu Since your change was applied there have been 32 commits pushed to the master branch:

c5462bb: 8255989: Remove explicitly unascribed authorship from Java source files
358f5d2: 6422025: ThemeReader.cpp can be updated for VC7
a9dff94: 8254864: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java timed out
0b7fba7: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c
f5d36e6: 8246741: NetworkInterface/UniqueMacAddressesTest: mac address uniqueness test failed
688b10b: 8255561: add tests to check binary compatibility rules for records
727a69f: 8255969: Improve java/io/BufferedInputStream/LargeCopyWithMark.java using jtreg tags
952abea: 8254920: Application launched with jpackage produced .exe crashes JVM
5dfb42f: 8255563: Missing NULL checks after JDK-8233624
e730e8b: 8241806: The sun/awt/shell/FileSystemViewMemoryLeak.java is unstable
... and 22 more: https://git.openjdk.java.net/jdk/compare/397bae20e9e6ae91a7d3ee74460e0e3c9da572f9...master

Your commit was automatically rebased without conflicts.

Pushed as commit 6a183fb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Reviewed-by: simonis

openjdk bot added the rfr Pull request is ready for review label Oct 30, 2020

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 30, 2020

navyxliu force-pushed the JDK-8255562 branch from 5f0eb67 to a4e875e Compare October 30, 2020 05:47

openjdk bot added the csr Pull request needs approved CSR before integration label Oct 30, 2020

TobiHartmann suggested changes Oct 30, 2020

View reviewed changes

src/hotspot/share/opto/machnode.hpp Outdated Show resolved Hide resolved

navyxliu force-pushed the JDK-8255562 branch from a4e875e to 478aab9 Compare November 5, 2020 02:33

openjdk bot added hotspot hotspot-dev@openjdk.org and removed hotspot-compiler hotspot-compiler-dev@openjdk.org labels Nov 5, 2020

Xin Liu added 2 commits November 5, 2020 05:44

8255562: delete UseRDPCForConstantTableBase

a91424f

8255562: delete UseRDPCForConstantTableBase

ae68617

mark UseRDPCForConstantTableBase is obsoletd in jdk16 and will expire in jdk17.

navyxliu force-pushed the JDK-8255562 branch from 478aab9 to ae68617 Compare November 5, 2020 05:45

simonis suggested changes Nov 5, 2020

View reviewed changes

8255562: delete UseRDPCForConstantTableBase

213a161

revert the change of Arguments::handle_aliases_and_deprecation. Arguments::process_argument can handle obsoleted arguments.

simonis approved these changes Nov 6, 2020

View reviewed changes

openjdk bot removed the csr Pull request needs approved CSR before integration label Nov 7, 2020

openjdk bot added the ready Pull request is ready to be integrated label Nov 7, 2020

openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 7, 2020

openjdk bot closed this Nov 8, 2020

openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 8, 2020

openjdk-notifier bot referenced this pull request Nov 8, 2020

8255562: delete UseRDPCForConstantTableBase

6a183fb

Reviewed-by: simonis

Uh oh!

8255562: delete UseRDPCForConstantTableBase #949

8255562: delete UseRDPCForConstantTableBase #949

Uh oh!

Conversation

navyxliu commented Oct 30, 2020 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Testing

Issue

Reviewers

Download

Uh oh!

bridgekeeper bot commented Oct 30, 2020

Uh oh!

openjdk bot commented Oct 30, 2020

Uh oh!

mlbridge bot commented Oct 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

vidmik commented Oct 30, 2020

Uh oh!

openjdk bot commented Oct 30, 2020

Uh oh!

Uh oh!

navyxliu commented Nov 5, 2020

Uh oh!

simonis left a comment

Choose a reason for hiding this comment

Uh oh!

simonis left a comment

Choose a reason for hiding this comment

Uh oh!

navyxliu commented Nov 6, 2020

Uh oh!

openjdk bot commented Nov 6, 2020

Uh oh!

simonis commented Nov 6, 2020

Uh oh!

openjdk bot commented Nov 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phohensee commented Nov 7, 2020

Uh oh!

openjdk bot commented Nov 7, 2020

Uh oh!

navyxliu commented Nov 7, 2020

Uh oh!

openjdk bot commented Nov 7, 2020

Uh oh!

phohensee commented Nov 8, 2020

Uh oh!

openjdk bot commented Nov 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

navyxliu commented Oct 30, 2020 •

edited by openjdk bot

Loading

mlbridge bot commented Oct 30, 2020 •

edited

Loading

openjdk bot commented Nov 7, 2020 •

edited

Loading