Skip to content

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Aug 4, 2021

Backport of JDK-8212040. Manual integration was needed due to JNF removal in the succeeding code.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8212040: Compilation error due to wrong usage of NSPrintJobDispositionValue in mac10.12

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/195/head:pull/195
$ git checkout pull/195

Update a local copy of the PR:
$ git checkout pull/195
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/195/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 195

View PR using the GUI difftool:
$ git pr show -t 195

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/195.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a7c90c54007eb73c602431b76060cde36dda3b34 8212040: Compilation error due to wrong usage of NSPrintJobDispositionValue in mac10.12 Aug 4, 2021
@openjdk
Copy link

openjdk bot commented Aug 4, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 4, 2021
@openjdk
Copy link

openjdk bot commented Aug 4, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8212040: Compilation error due to wrong usage of NSPrintJobDispositionValue in mac10.12

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • d05effd: 8270893: IndexOutOfBoundsException while reading large TIFF file

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 4, 2021
@TheRealMDoerr TheRealMDoerr marked this pull request as ready for review August 4, 2021 18:17
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 4, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 4, 2021

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 5, 2021

Going to push as commit 1223b58.
Since your change was applied there have been 4 commits pushed to the master branch:

  • b878e3f: 8263432: javac may report an invalid package/class clash on case insensitive filesystems
  • f2240cc: 8221988: add possibility to build with Visual Studio 2019
  • 87e300b: 8220445: Support for side by side MSVC Toolset versions
  • d05effd: 8270893: IndexOutOfBoundsException while reading large TIFF file

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 5, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 5, 2021
@openjdk
Copy link

openjdk bot commented Aug 5, 2021

@TheRealMDoerr Pushed as commit 1223b58.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8212040_mac_printer branch August 5, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant