8248001: javadoc generates invalid HTML pages whose ftp:// links are broken

[ktakakuri]

I would like to backport
8248001: javadoc generates invalid HTML pages whose ftp:// links are broken.
There are minor differences regarding DocRoot, but otherwise this is a clean backport.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8248001: javadoc generates invalid HTML pages whose ftp:// links are broken (Bug - P4)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2002/head:pull/2002
$ git checkout pull/2002

Update a local copy of the PR:
$ git checkout pull/2002
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2002/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2002

View PR using the GUI difftool:
$ git pr show -t 2002

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2002.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (1831e33d)
• 00: Full (a6008b0d)

[phohensee]

Testing?

[ktakakuri]

I built and tested test/langtools on Windows x86_64, and confirmed that all tests passed.

[openjdk]

@ktakakuri This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8248001: javadoc generates invalid HTML pages whose ftp:// links are broken

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 2c54727: 8299713: Test javax/swing/JTableHeader/6889007/bug6889007.java failed: Wrong type of cursor

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[GoeLin]

@ ktakakuri , please enable the pre-submit tests.
Merging head will trigger them to run.

[ktakakuri]

linux-cross-compile failed.

E: Version '10.3.0-1ubuntu1~20.04cross1' for 'gcc-10-s390x-linux-gnu' was not found
E: Version '10.3.0-1ubuntu1~20.04cross1' for 'g++-10-s390x-linux-gnu' was not found

But all other tests passed.
Is it OK?

[phohensee]

It's ok, looks like a GHA infra failure.

[ktakakuri]

/integrate

[openjdk]

@ktakakuri
Your change (at version 1831e33) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit f5f17ec.
Since your change was applied there has been 1 commit pushed to the master branch:

• 2c54727: 8299713: Test javax/swing/JTableHeader/6889007/bug6889007.java failed: Wrong type of cursor

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @ktakakuri Pushed as commit f5f17ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.