-
Notifications
You must be signed in to change notification settings - Fork 252
8263188: JSSE should fail fast if there isn't supported signature algorithm #3126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back avieiro! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
(Is there a GitHub - JIRA sync issue? I've updated the PR title manually) |
|
@vieiro Changing the title manually won't help as then the patch isn't being recognized as backport. Please use the fulll sha and try again: |
|
This backport pull request has now been updated with issue from the original commit. |
a2a223a to
b17720d
Compare
|
@vieiro Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
I've rebased on master to get the recently merged JDK-8341964 and JDK-8245545 on this branch. And retested with |
jerboaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please update the copyright since another change happend since and there is no THL A29 Limited in other copyright notices anymore.
test/jdk/sun/security/ssl/SignatureScheme/SigAlgosExtTestWithTLS12.java
Outdated
Show resolved
Hide resolved
test/jdk/sun/security/ssl/SignatureScheme/SigAlgosExtTestWithTLS13.java
Outdated
Show resolved
Hide resolved
|
/issue add JDK-8364597 |
|
@vieiro |
|
Please don't add 8364597 to the issues list. It's already done for 11u. That's the business we are in when doing backports. Remember when to adjust a backport if they came in out-of-order. |
|
/issue remove JDK-8364597 |
|
@vieiro |
Thanks for the tip! I thought we wanted to keep track of related commits too. Good to know! |
Things like this are good candidates to mention in the approval comments. |
jerboaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
|
|
/approval request Please consider approving this PR that makes it easier for future backports to follow the Oracle JRE and JDK Cryptographic Roadmap on 2026/01 by disabling SHA-1 in TLS/DTLS 1.2 handshake signatures. The reviewer has kindly reminded to also update the copyright changes introduced in the later JDK-8364597. |
Clean backport of JDK-8263188 to JDK11.
It will make it easier to backport and review JDK-8349583 and JDK-8340321 , so OpenJDK 11 follows the Oracle JRE and JDK Cryptographic Roadmap on 2026/01 by disabling SHA-1 in TLS/DTLS 1.2 handshake signatures.
Since JDK11 does not sport the
ByteBuffer.slice(int, int)method in JDK17 (used intest/jdk/sun/security/ssl/SignatureScheme/SigAlgosExtTestWithTLS12.java), a second commit adds an equivalent and updates the test.Tested on Linux with
tier1tests:Also security tests (including new ones) pass:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3126/head:pull/3126$ git checkout pull/3126Update a local copy of the PR:
$ git checkout pull/3126$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3126/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3126View PR using the GUI difftool:
$ git pr show -t 3126Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3126.diff
Using Webrev
Link to Webrev Comment