Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8244087: 2020-04-24 public suffix list update v ff6fcea #201

Closed
wants to merge 1 commit into from

Conversation

dimitryc
Copy link
Collaborator

@dimitryc dimitryc commented May 7, 2021

8244087: 2020-04-24 public suffix list update v ff6fcea


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8244087: 2020-04-24 public suffix list update v ff6fcea

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/201/head:pull/201
$ git checkout pull/201

Update a local copy of the PR:
$ git checkout pull/201
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/201/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 201

View PR using the GUI difftool:
$ git pr show -t 201

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/201.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 7, 2021

👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 07cb35a9f3122673b8eeae1f3c84fdb6be5c46af 8244087: 2020-04-24 public suffix list update v ff6fcea May 7, 2021
@openjdk
Copy link

openjdk bot commented May 7, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 7, 2021

@dimitryc This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8244087: 2020-04-24 public suffix list update v ff6fcea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • fac6c49: 8242184: Default signature algorithm for an RSASSA-PSS key
  • d46f297: 8231118: ARM32: Math tests failures

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 7, 2021
@mlbridge
Copy link

mlbridge bot commented May 7, 2021

Webrevs

@dimitryc
Copy link
Collaborator Author

dimitryc commented May 7, 2021

/integrate

@openjdk openjdk bot closed this May 7, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 7, 2021
@openjdk
Copy link

openjdk bot commented May 7, 2021

@dimitryc Since your change was applied there have been 2 commits pushed to the master branch:

  • fac6c49: 8242184: Default signature algorithm for an RSASSA-PSS key
  • d46f297: 8231118: ARM32: Math tests failures

Your commit was automatically rebased without conflicts.

Pushed as commit 56ed2b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dimitryc dimitryc deleted the backport-8244087 branch May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant