Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Conversation

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Jan 21, 2022

fix applies cleanly, hotspot tests run OK


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272570: C2: crash in PhaseCFG::global_code_motion

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/311/head:pull/311
$ git checkout pull/311

Update a local copy of the PR:
$ git checkout pull/311
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/311/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 311

View PR using the GUI difftool:
$ git pr show -t 311

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/311.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 21, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0f428ca533627e758cdca599d4589f39c21e27b6 8272570: C2: crash in PhaseCFG::global_code_motion Jan 21, 2022
@openjdk
Copy link

openjdk bot commented Jan 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 21, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8272570: C2: crash in PhaseCFG::global_code_motion

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 21, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 21, 2022

Webrevs

@yan-too
Copy link
Collaborator Author

yan-too commented Jan 21, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 21, 2022

Going to push as commit 4e04312.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 21, 2022
@openjdk openjdk bot closed this Jan 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 21, 2022
@openjdk
Copy link

openjdk bot commented Jan 21, 2022

@yan-too Pushed as commit 4e04312.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8272570 branch January 21, 2022 09:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant