Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Conversation

@gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented May 30, 2022

This change was part of a security fix, JDK-8277233, for 17u during the April update. The rest of 8277233 did not apply to older releases, as it concerned code added to src/jdk.crypto.ec/share/classes/sun/security/ec/ECDSAOperations.java by JDK-8237218 in 15u.

However, the additional checks in src/java.base/share/classes/sun/security/provider/DSA.java that were included in the patch are applicable to older releases.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285591: [11] add signum checks in DSA.java engineVerify

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/353/head:pull/353
$ git checkout pull/353

Update a local copy of the PR:
$ git checkout pull/353
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/353/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 353

View PR using the GUI difftool:
$ git pr show -t 353

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/353.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2022

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bf3438c5dc993b96d089cabb5318bfc64a6904a3 8285591: [11] add signum checks in DSA.java engineVerify May 30, 2022
@openjdk
Copy link

openjdk bot commented May 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 30, 2022

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285591: [11] add signum checks in DSA.java engineVerify

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 30, 2022
@mlbridge
Copy link

mlbridge bot commented May 30, 2022

Webrevs

@gnu-andrew
Copy link
Member Author

I see jdk13u-fix-yes

@gnu-andrew
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 2, 2022

Going to push as commit b34726f.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 18a73c0: 8255035: Update BCEL to Version 6.5.0
  • 77d548c: 8270886: Crash in PhaseIdealLoop::verify_strip_mined_scheduling

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 2, 2022
@openjdk openjdk bot closed this Jun 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 2, 2022
@openjdk
Copy link

openjdk bot commented Jun 2, 2022

@gnu-andrew Pushed as commit b34726f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant