Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Conversation

@dimitryc
Copy link
Collaborator

@dimitryc dimitryc commented Dec 1, 2021

Clean backport.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/148/head:pull/148
$ git checkout pull/148

Update a local copy of the PR:
$ git checkout pull/148
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 148

View PR using the GUI difftool:
$ git pr show -t 148

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/148.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2021

👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 80323b7f66541e24177d02cc668a2eb9267962b9 8261169: Upgrade HarfBuzz to the latest 2.8.0 Dec 1, 2021
@openjdk
Copy link

openjdk bot commented Dec 1, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 1, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 1, 2021

Webrevs

Copy link
Collaborator

@yan-too yan-too left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing the original patch to 'patch -p 1' work absolutely without problems, with a single offset of 2 lines in one file. Why skara thinks it is not clean? Anyway, LGTM.

@openjdk
Copy link

openjdk bot commented Dec 1, 2021

@dimitryc This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261169: Upgrade HarfBuzz to the latest 2.8.0

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 1, 2021
@dimitryc
Copy link
Collaborator Author

dimitryc commented Dec 1, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 1, 2021

Going to push as commit cc85ccb.

@openjdk openjdk bot closed this Dec 1, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2021
@openjdk
Copy link

openjdk bot commented Dec 1, 2021

@dimitryc Pushed as commit cc85ccb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dimitryc dimitryc deleted the backport-8261169-harfbuzz-2.8.0 branch December 1, 2021 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants