-
Notifications
You must be signed in to change notification settings - Fork 30
8261169: Upgrade HarfBuzz to the latest 2.8.0 #148
Conversation
|
👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
yan-too
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing the original patch to 'patch -p 1' work absolutely without problems, with a single offset of 2 lines in one file. Why skara thinks it is not clean? Anyway, LGTM.
|
@dimitryc This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit cc85ccb. |
Clean backport.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/148/head:pull/148$ git checkout pull/148Update a local copy of the PR:
$ git checkout pull/148$ git pull https://git.openjdk.java.net/jdk15u-dev pull/148/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 148View PR using the GUI difftool:
$ git pr show -t 148Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/148.diff