Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Conversation

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Apr 27, 2022

Backport for parity with major releases. Some context changes were necessary in source part; private toHex function was used instead of HexFormat; and I borrowed test/lib/jdk/test/lib/security/SecurityUtils.java from JDK 11.
All JDK security tests run OK.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278851: Correct signer logic for jars signed with multiple digest algorithms

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/202/head:pull/202
$ git checkout pull/202

Update a local copy of the PR:
$ git checkout pull/202
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/202/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 202

View PR using the GUI difftool:
$ git pr show -t 202

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/202.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 27, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 61b8944327e3d12cf58dc3f6bc45ecbeba4ef611 8278851: Correct signer logic for jars signed with multiple digest algorithms Apr 27, 2022
@openjdk
Copy link

openjdk bot commented Apr 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 27, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 27, 2022

Webrevs

Copy link
Collaborator

@bae bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@openjdk
Copy link

openjdk bot commented Apr 27, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8278851: Correct signer logic for jars signed with multiple digest algorithms

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • a6be0e0: 8285445: cannot open file "NUL:"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 27, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Apr 27, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 27, 2022

Going to push as commit d148e26.
Since your change was applied there has been 1 commit pushed to the master branch:

  • a6be0e0: 8285445: cannot open file "NUL:"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 27, 2022
@openjdk openjdk bot closed this Apr 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 27, 2022
@openjdk
Copy link

openjdk bot commented Apr 27, 2022

@yan-too Pushed as commit d148e26.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8278851 branch April 27, 2022 12:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants