-
Notifications
You must be signed in to change notification settings - Fork 27
8278851: Correct signer logic for jars signed with multiple digest algorithms #202
Conversation
|
👋 Welcome back yan! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
bae
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
|
@yan-too This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
Backport for parity with major releases. Some context changes were necessary in source part; private toHex function was used instead of HexFormat; and I borrowed test/lib/jdk/test/lib/security/SecurityUtils.java from JDK 11.
All JDK security tests run OK.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/202/head:pull/202$ git checkout pull/202Update a local copy of the PR:
$ git checkout pull/202$ git pull https://git.openjdk.java.net/jdk15u-dev pull/202/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 202View PR using the GUI difftool:
$ git pr show -t 202Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/202.diff