Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Conversation

@gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Dec 14, 2022

Clean backport of the latest tzdata update.

This pull request contains a backport of commit ce896731 from the openjdk/jdk repository.

The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato.

Tests in java/util/TimeZone, java/time/test, sun/util/calendar, sun/util/resources and sun/text/resources all pass.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/317/head:pull/317
$ git checkout pull/317

Update a local copy of the PR:
$ git checkout pull/317
$ git pull https://git.openjdk.org/jdk15u-dev pull/317/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 317

View PR using the GUI difftool:
$ git pr show -t 317

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/317.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2022

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ce896731d38866c2bf99cd49525062e150d94160 8297804: (tz) Update Timezone Data to 2022g Dec 14, 2022
@openjdk
Copy link

openjdk bot commented Dec 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 14, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 14, 2022

Webrevs

@gnu-andrew
Copy link
Member Author

/clean

@openjdk openjdk bot added the clean label Dec 14, 2022
@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@gnu-andrew This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8297804: (tz) Update Timezone Data to 2022g

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 14, 2022
@yan-too
Copy link
Collaborator

yan-too commented Dec 19, 2022

Thank you, @gnu-andrew ! Marked jdk15u-fix-yes. Sorry I was away for a week. Hope you will integrate before Dec 21-th; otherwise we'll change repository to jdk15u and label to critical.

@gnu-andrew
Copy link
Member Author

Thank you, @gnu-andrew ! Marked jdk15u-fix-yes. Sorry I was away for a week. Hope you will integrate before Dec 21-th; otherwise we'll change repository to jdk15u and label to critical.

No worries and thanks for the approval. I'll integrate now.

I also have 13u in the pipeline. Should I target that to jdk13u or is there still time to get it in via jdk13u-dev? Should have a PR ready in the next few hours.

@gnu-andrew
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 20, 2022

Going to push as commit 5c1a24f.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 20, 2022
@openjdk openjdk bot closed this Dec 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 20, 2022
@openjdk
Copy link

openjdk bot commented Dec 20, 2022

@gnu-andrew Pushed as commit 5c1a24f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gnu-andrew
Copy link
Member Author

Thank you, @gnu-andrew ! Marked jdk15u-fix-yes. Sorry I was away for a week. Hope you will integrate before Dec 21-th; otherwise we'll change repository to jdk15u and label to critical.

No worries and thanks for the approval. I'll integrate now.

I also have 13u in the pipeline. Should I target that to jdk13u or is there still time to get it in via jdk13u-dev? Should have a PR ready in the next few hours.

13u: openjdk/jdk13u-dev#444

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants