Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 11, 2023

I backport this for parity with 17.0.7-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295116: C2: assert(dead->outcnt() == 0 && !dead->is_top()) failed: node must be dead

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1057/head:pull/1057
$ git checkout pull/1057

Update a local copy of the PR:
$ git checkout pull/1057
$ git pull https://git.openjdk.org/jdk17u-dev pull/1057/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1057

View PR using the GUI difftool:
$ git pr show -t 1057

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1057.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 94575d14f47e2dfb11b671bce26b69270b6bb3c8 8295116: C2: assert(dead->outcnt() == 0 && !dead->is_top()) failed: node must be dead Jan 11, 2023
@openjdk
Copy link

openjdk bot commented Jan 11, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 11, 2023
@openjdk
Copy link

openjdk bot commented Jan 11, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295116: C2: assert(dead->outcnt() == 0 && !dead->is_top()) failed: node must be dead

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 11, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 11, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jan 12, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 12, 2023

Going to push as commit 772f90a.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 08e30d0: 8297951: C2: Create skeleton predicates for all If nodes in loop predication
  • f8a8417: 8299388: java/util/regex/NegativeArraySize.java fails on Alpine and sometimes Windows
  • ead3081: 8296619: Upgrade jQuery to 3.6.1
  • 0db4add: 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events
  • eceb480: 8267038: Update IANA Language Subtag Registry to Version 2022-03-02
  • ffecc39: 8295788: C2 compilation hits "assert((mode == ControlAroundStripMined && use == sfpt) || !use->is_reachable_from_root()) failed: missed a node"
  • 520ae87: 8284165: Add pid to process reaper thread name
  • 3722edc: 8284726: Print active locale settings in hs_err reports and in VM.info

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 12, 2023
@openjdk openjdk bot closed this Jan 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 12, 2023
@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@GoeLin Pushed as commit 772f90a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant