8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling

[GoeLin]

I backport this for parity with 17.0.8-oracle.

I had to resolve loopopts.cpp because formatting has
been fixed in head.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1306/head:pull/1306
$ git checkout pull/1306

Update a local copy of the PR:
$ git checkout pull/1306
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1306/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1306

View PR using the GUI difftool:
$ git pr show -t 1306

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1306.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (7af9a93a)

[shipilev]

Looks fine. I assume the regression test fails before the patch and passes after?

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 04eb720.
Since your change was applied there have been 9 commits pushed to the master branch:

• 345e370: 8303861: Error handling step timeouts should never be blocked by OnError and others
• 5ed9696: 8305481: gtest is_first_C_frame failing on ARM
• 96adf07: 8297955: LDAP CertStore should use LdapName and not String for DNs
• 65a02da: 8303476: Add the runtime version in the release file of a JDK image
• 07993bf: 8287897: Augment src/jdk.internal.le/share/legal/jline.md with information on 4th party dependencies
• 5296357: 8303822: gtestMain should give more helpful output
• aa8c46c: 8301190: [vectorapi] The typeChar of LaneType is incorrect when default locale is tr
• b2f16a5: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space
• a485033: 8306883: Thread stacksize is reported with wrong units in os::create_thread logging

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 04eb720.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[GoeLin]

I assume the regression test fails before the patch and passes after?
Sorry, I only saw this now. As I stated in the JBS issue the test does not reproduce the problem without the fix.