Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented May 19, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301661: Enhance os::pd_print_cpu_info on macOS and Windows

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1376/head:pull/1376
$ git checkout pull/1376

Update a local copy of the PR:
$ git checkout pull/1376
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1376/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1376

View PR using the GUI difftool:
$ git pr show -t 1376

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1376.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 19, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9145670354c41381614877aa71895dc2bd5cce9d 8301661: Enhance os::pd_print_cpu_info on macOS and Windows May 19, 2023
@openjdk
Copy link

openjdk bot commented May 19, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels May 19, 2023
@openjdk
Copy link

openjdk bot commented May 19, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301661: Enhance os::pd_print_cpu_info on macOS and Windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 19, 2023
@mlbridge
Copy link

mlbridge bot commented May 19, 2023

Webrevs

@GoeLin
Copy link
Member

GoeLin commented May 22, 2023

@MBaesken, please restart GHA by merging head. It seems to hang.

@MBaesken
Copy link
Member Author

I synced the fork https://github.com/openjdk-bots/jdk17u-dev/tree/MBaesken-backport-91456703 , let's see what that does with the GHAs .
Usually the GHA's should be restartable under 'Actions' in my fork but unfortunately I do not see this one there; looks all a bit strange to me ...

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 26, 2023

Going to push as commit 6803da9.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 0d2cc35: 8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses
  • 5bf1b9a: 8283520: JFR: Memory leak in dcmd_arena
  • c581886: 8307128: Open source some drag and drop tests 4
  • 14779b1: 8294717: (bf) DirectByteBuffer constructor will leak if allocating Deallocator or Cleaner fails with OOME
  • 57d0a7f: 8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors
  • 436d96f: 8275287: Relax memory ordering constraints on updating instance class and array class counters
  • 50aabaa: 8307347: serviceability/sa/ClhsdbDumpclass.java could leave files owned by root on macOS
  • 861fe74: 8274615: Support relaxed atomic add for linux-aarch64
  • fe17568: 8307135: java/awt/dnd/NotReallySerializableTest/NotReallySerializableTest.java failed
  • 464a32b: 8227060: Optimize safepoint cleanup subtask order
  • ... and 17 more: https://git.openjdk.org/jdk17u-dev/compare/17b364016fe54311d8ed173abf7c42b713011fa1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 26, 2023
@openjdk openjdk bot closed this May 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 26, 2023
@openjdk
Copy link

openjdk bot commented May 26, 2023

@MBaesken Pushed as commit 6803da9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants