Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Jun 13, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309297: Adjust ShenandoahHeap print_heap_regions_on (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1426/head:pull/1426
$ git checkout pull/1426

Update a local copy of the PR:
$ git checkout pull/1426
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1426/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1426

View PR using the GUI difftool:
$ git pr show -t 1426

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1426.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 13, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9233dcc8380c6e7cd7bbf7a1f4c0a6873429ea53 8309297: Adjust ShenandoahHeap print_heap_regions_on Jun 13, 2023
@openjdk
Copy link

openjdk bot commented Jun 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 13, 2023
@openjdk
Copy link

openjdk bot commented Jun 13, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309297: Adjust ShenandoahHeap print_heap_regions_on

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • f80be82: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 13, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 13, 2023

Webrevs

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 14, 2023

Going to push as commit ebb9a36.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 8ac9c57: Merge
  • 0f531da: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates
  • 22a548b: 8307395: Add missing STS to Shenandoah
  • 12d08f0: 8308156: VerifyCACerts.java misses blank in error output
  • e898048: 8307572: AArch64: Vector registers are clobbered by some macroassemblers
  • f80be82: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree()

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 14, 2023
@openjdk openjdk bot closed this Jun 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 14, 2023
@openjdk
Copy link

openjdk bot commented Jun 14, 2023

@MBaesken Pushed as commit ebb9a36.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant