Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Jun 16, 2023

Clean backport to substantially improve testing performance.

Additional testing:

  • The similar testing time improvements on original test
  • Linux x86_64 fastdebug tier1 tier2 tier3
  • Linux AArch64 fastdebug tier1 tier2 tier3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290464: Optimize ResourceArea zapping on ResourceMark release (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1452/head:pull/1452
$ git checkout pull/1452

Update a local copy of the PR:
$ git checkout pull/1452
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1452/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1452

View PR using the GUI difftool:
$ git pr show -t 1452

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1452.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7841e5cc387ba595f73f40b3a0d00d7e36df15ea 8290464: Optimize ResourceArea zapping on ResourceMark release Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290464: Optimize ResourceArea zapping on ResourceMark release

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 9181535: 8300584: Accelerate AVX-512 CRC32C for small buffers
  • 2b5b9f5: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM
  • 2bed865: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox
  • eed854c: 8309340: Provide sctpHandleSocketErrorWithMessage
  • f9a6075: 8302150: Speed up compiler/codegen/Test7100757.java
  • 954bbaa: 8282651: ZGC: vmTestbase/gc/ArrayJuggle/ tests fails intermittently with exit code 97
  • 30d0484: 8299962: Speed up compiler/intrinsics/unsafe/DirectByteBufferTest.java and HeapByteBufferTest.java
  • 31a7fd3: 8298921: Create a regression test for JDK-8139581
  • faafe22: 8305858: Resolve multiple definition of 'handleSocketError' when statically linking with JDK native libraries
  • 01ac9cb: 8309138: Fix container tests for jdks with symlinked conf dir

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 16, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2023

Webrevs

@shipilev
Copy link
Member Author

Push approval is here. Testing is clean. Change was in mainline for about a year with no bug tail.

/integrate

@openjdk
Copy link

openjdk bot commented Jun 29, 2023

Going to push as commit 295cf44.
Since your change was applied there have been 67 commits pushed to the master branch:

  • b8a0a22: 8295812: Skip the "half float" support in LittleCMS during the build
  • 3d53b27: 8308152: PropertyDescriptor should work with overridden generic getter method
  • 95b4ddc: 8310126: C1: Missing receiver null check in Reference::get intrinsic
  • 4fd0ee5: 8305425: Thread.isAlive0 doesn't need to call into the VM
  • 8204dfa: 8289238: Refactoring changes to PassFailJFrame Test Framework
  • d27e56e: 8305950: Have -XshowSettings option display tzdata version
  • 9b89523: 8298974: Add ftcolor.c to imported freetype sources
  • 5021a07: 8287227: Shenandoah: A couple of virtual thread tests failed with iu mode even without Loom enabled.
  • b8a65e0: 8277654: Shenandoah: Don't produce new memory state in C2 LRB runtime call
  • 832707b: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)
  • ... and 57 more: https://git.openjdk.org/jdk17u-dev/compare/6991372a06f7e623112f1437eeaed7ad7eb6eb99...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 29, 2023
@openjdk openjdk bot closed this Jun 29, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 29, 2023
@openjdk
Copy link

openjdk bot commented Jun 29, 2023

@shipilev Pushed as commit 295cf44.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8290464-resource-area-zapping branch July 20, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant