Skip to content

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 21, 2023

Backport of JDK-8300659. Clean except Copyright year update.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300659: Refactor TestMemoryAwareness to use WhiteBox api for host values (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1484/head:pull/1484
$ git checkout pull/1484

Update a local copy of the PR:
$ git checkout pull/1484
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1484/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1484

View PR using the GUI difftool:
$ git pr show -t 1484

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1484.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2023

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3c61d5aa48606dab2d2c639d5f0a56313476917d 8300659: Refactor TestMemoryAwareness to use WhiteBox api for host values Jun 21, 2023
@openjdk
Copy link

openjdk bot commented Jun 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jun 21, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2023

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/clean

@openjdk openjdk bot added the clean Identical backport; no merge resolution required label Jun 22, 2023
@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@TheRealMDoerr This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300659: Refactor TestMemoryAwareness to use WhiteBox api for host values

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 9a49698: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 22, 2023
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 22, 2023

Going to push as commit 781df52.
Since your change was applied there have been 2 commits pushed to the master branch:

  • ab27843: 8283056: show abstract machine code in hs-err for all VM crashes
  • 9a49698: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 22, 2023
@openjdk openjdk bot closed this Jun 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 22, 2023
@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@TheRealMDoerr Pushed as commit 781df52.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8300659_TestMemoryAwareness branch June 22, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant