-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8293107: GHA: Bump to Ubuntu 22.04 #1640
Conversation
… host and cross builds
…ke and configure arguments
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/issue add 8293098,8293107,8293361,8295213,8313428,8313707 |
@shipilev Adding additional issue to issue list: Adding additional issue to issue list: Adding additional issue to issue list: Adding additional issue to issue list: |
@RealCLanger, @TheRealMDoerr -- this approach makes sense to you? If so, I'll mark this PR ready for review. It would add the PR links to all affected issues, which I don't want to do unless we are going forward with this PR. |
Yep, that makes sense. Thanks for the work, happy to review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for bringing GHA in 17u up to date.
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks! I added 17u fix requests on all issues. |
Please see my comment in JDK-8293107 |
The discussion seem to be resolved. The recent GHA run is clean. /integrate |
Going to push as commit 260f287.
Your commit was automatically rebased without conflicts. |
This is a series of commits that bring 17u GHA close to mainline. The root change is Ubuntu 22.04 bump, but that one could not be tested alone, because GHA would be broken due to missing compilers, dependencies, etc. Therefore, I opted to do a bulk PR that contains a series of inter-dependent changes. This PR should bring 17u GHA to the good state, atomically.
The included changes are in separate commits, if you want to review them separately. But it would be easier to see the changes against JDK 22 GHA. There are differences against JDK 22 GHA, but those look minor, not breaking/fixing current GHA, and we can backport separately once we get JDK 17u GHA in shape.
Additional testing:
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1640/head:pull/1640
$ git checkout pull/1640
Update a local copy of the PR:
$ git checkout pull/1640
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1640/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1640
View PR using the GUI difftool:
$ git pr show -t 1640
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1640.diff
Webrev
Link to Webrev Comment