Skip to content

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Aug 8, 2023

Backport of JDK-8255548.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1649/head:pull/1649
$ git checkout pull/1649

Update a local copy of the PR:
$ git checkout pull/1649
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1649/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1649

View PR using the GUI difftool:
$ git pr show -t 1649

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1649.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 8, 2023

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 76cda9f44a80b1979e6e1b7a21431ef631f80782 8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext Aug 8, 2023
@openjdk
Copy link

openjdk bot commented Aug 8, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 8, 2023
@openjdk
Copy link

openjdk bot commented Aug 8, 2023

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 8, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 8, 2023

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 10, 2023

Going to push as commit fe9b7c6.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 242513f: 6381945: (cal) Japanese calendar unit test system should avoid multiple static imports
  • 3d86810: 8307079: Update test java/awt/Choice/DragOffNoSelect.java
  • 8aad696: 8301167: Update VerifySignedJar to actually exercise and test verification
  • fe3920e: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs
  • ec2abc2: 8302182: Update Public Suffix List to 88467c9
  • 9c8731b: 8309095: Remove UTF-8 character from TaskbarPositionTest.java
  • 4786a00: 8267860: Off-by-one bug when searching arrays in AlpnGreaseTest
  • 2f5a952: 8195589: T6587786.java failed after JDK-8189997
  • 6349de6: 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment
  • a5cdc22: 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 10, 2023
@openjdk openjdk bot closed this Aug 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 10, 2023
@openjdk
Copy link

openjdk bot commented Aug 10, 2023

@TheRealMDoerr Pushed as commit fe9b7c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant