Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free #1706

Closed
wants to merge 4 commits into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Aug 29, 2023

Hi all,

This pull request contains a backport of commit 7c2c5858 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 12 Dec 2021 and was reviewed by Prasanta Sadhukhan and Alexey Ivanov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8276819 needs maintainer approval

Issue

  • JDK-8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1706/head:pull/1706
$ git checkout pull/1706

Update a local copy of the PR:
$ git checkout pull/1706
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1706/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1706

View PR using the GUI difftool:
$ git pr show -t 1706

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1706.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 29, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7c2c58587d4eda5523331eae45e7d897252dc097 8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free Aug 29, 2023
@openjdk
Copy link

openjdk bot commented Aug 29, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Aug 29, 2023
@mrserb mrserb changed the base branch from master to pr/1625 August 29, 2023 06:49
@openjdk openjdk bot added the clean label Aug 29, 2023
@mrserb mrserb marked this pull request as ready for review August 29, 2023 06:52
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 29, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 29, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 26, 2023

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2023

@mrserb This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Oct 24, 2023
@mrserb
Copy link
Member Author

mrserb commented Nov 7, 2023

/open

@openjdk openjdk bot reopened this Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@mrserb This pull request is now open

@openjdk openjdk bot removed the clean label Nov 7, 2023
@mrserb mrserb changed the base branch from pr/1625 to master November 8, 2023 01:02
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@mrserb Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the clean label Nov 8, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 8, 2023
@mrserb
Copy link
Member Author

mrserb commented Nov 8, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 8, 2023

Going to push as commit 1240b34.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 8, 2023
@openjdk openjdk bot closed this Nov 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 8, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@mrserb Pushed as commit 1240b34.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant