Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277383: VM.metaspace optionally show chunk freelist details #173

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Feb 23, 2022

I'd like to backport this to jdk17 since it adds a useful option for metaspace analysis. Fix is low risk and applies cleanly.

The commit being backported was authored by Thomas Stuefe on 7 Dec 2021 and was reviewed by Coleen Phillimore and Aleksey Shipilev.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277383: VM.metaspace optionally show chunk freelist details

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/173/head:pull/173
$ git checkout pull/173

Update a local copy of the PR:
$ git checkout pull/173
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/173/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 173

View PR using the GUI difftool:
$ git pr show -t 173

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/173.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 23, 2022

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 35361270cb3aae9fa560736f8d05f1b258704c87 8277383: VM.metaspace optionally show chunk freelist details Feb 23, 2022
@openjdk
Copy link

openjdk bot commented Feb 23, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 23, 2022

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277383: VM.metaspace optionally show chunk freelist details

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 23, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 23, 2022

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented Feb 23, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 23, 2022

Going to push as commit 0c6e662.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 9bb8b7f: 8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 23, 2022
@openjdk openjdk bot closed this Feb 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 23, 2022
@openjdk
Copy link

openjdk bot commented Feb 23, 2022

@tstuefe Pushed as commit 0c6e662.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant